Comments (4)
Hi René!
Thank you so much for getting back to me and clarifying. I think adding that to the documentation might be useful in the future since I know of other people using this algorithm to look for planets around hot subdwarfs and m dwarfs, which would both have very different Roche radii.
And yes, for my case, since the Roche radius is inside the star, I am just setting the minimum semi major axis to be
Thank you again!
from tls.
Hi @toribonidie, thank you for your question. This seems less like a code question, assuming the code replicates the paper correctly. Instead, I believe your question is better answered with physical reasoning. I'm a little tight on time at the moment, but I'll try to ping my co-author René for an answer.
from tls.
Hi @hippke ! Thank you for getting back to me. Please take your time to respond. I am able to override the default period grid that TLS provides while performing my searches, but I just wanted to make sure I'm interpreting this correctly so that I am not searching for periods that are physically impossible.
So, no rush! But I look forward to hearing back from you or René for clarification.
from tls.
Hello @toribonidie! Your calculations look alright to me. Our formulae have been adopted from Ofir (2014), see his Sect. 3.1 therein for a few more details. In brief, yes, fmax is derived from Kepler's 3rd Law as you illustrate. The factor of 3 Rs comes from the division of the stellar density by the planetary density and then taking the third root. For a fluid-like Sun-like star and very low-density planet, we have 2.44 × (ρs/ρp)1/3 ~ 2.44 × (1.4 g cm-3 / 1 g cm-3)1/3 ~ 2.44 × 1.12 ~ 2.73 ~ 3.
I checked our paper and you're right, we should have explicitly mentioned that we assumed a solar-type star. In fact, for low-mass stars the density is higher than for solar-type stars and the Roche limit can move out to ~ 10 Rs. Michael (@hippke), maybe this is something that we should note in the TLS documentation for users to be aware that it might make sense to adjust the Roche limit and therefore fmax?
Tori, for your particular case of an extremely low-density star you end up with a Roche radius inside the star, did you notice? a3 between 0.004 Rs3 and 0.03 Rs3 is equivalent to a between 0.16 Rs and 0.3 Rs. I would expect any planet at that "distance" to the star to lose angular momentum and fall into the stellar core within < 1 million years. What do you think?
from tls.
Related Issues (20)
- catalog_info_ returning the errors for radius/mass_min/max instead of the min/max values HOT 1
- Bug
- TLS failing for Kepler prime mission data HOT 5
- Dependency on batman / numpy makes it impossible to install TLS HOT 3
- MultiProcessing Bug with M1 Pro chipped Mac books HOT 2
- Non-integer oversampling factors cause index error in TLS pipeline
- Why TLS use duration from minimum chi2 period instead of maximum power period? HOT 6
- Setting minimum duration limit HOT 2
- Occasional buggy spectrum if array of equal errors given HOT 3
- Bug: calls numpy.int which is deprecated since numpy version 1.20 HOT 2
- Period Grid error in stellar mass (maybe radius too?) > 1 HOT 13
- Insert Sort on previous trial period
- Bug: Default Limb Darkening Coefficients overriding input HOT 2
- Smooth the periodograms with log-normal biweight
- Bug: Can't install due to batman-package failure HOT 6
- Relax minimum period HOT 4
- Bug: expected dtype object, got 'numpy.dtype[float64]' with numpy 1.21 HOT 4
- Add `verbose` kwarg to transitleastsquares HOT 6
- Bug running multiprocessing. HOT 8
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tls.