Bug: `encoding` option in requestBody is not respected. about openapi-typescript-code-generator HOT 4 CLOSED

you can check in playground v0,25.0

https://openapi-typescript-code-generator.netlify.app/v0.25.0/index.html

Perhaps the Himenon/openapi-parameter-formatter would work well.

from openapi-typescript-code-generator.

Thanks for the info. It looks like I will need to change the ApiClient interface to implement this.

export interface ApiClient<RequestOption> {
    request: <T = SuccessResponses>(httpMethod: HttpMethod, url: string, headers: ObjectLike | any, requestBody: ObjectLike | any, queryParameters: QueryParameters | undefined, options?: RequestOption) => Promise<T>;
}

Should I make the argument an object if I expect to add more in the future?

I would like to hear your opinion.

from openapi-typescript-code-generator.

Should I make the argument an object if I expect to add more in the future?

IMO, accepting object as an argument is a good choice.
However this causes breaking change.So I think we have to bump major version.(It would be better to have version 1.0.0 before making this change.)

from openapi-typescript-code-generator.

I also agree this. I think it's a common best practice to keep public API arguments defines as dict.

from openapi-typescript-code-generator.