Fix arbitrarily failing tests due to possible Mapping inequality? about hikari HOT 2 CLOSED

https://travis-ci.com/github/nekokatt/hikari/jobs/385663836
https://travis-ci.com/github/nekokatt/hikari/jobs/385663837

Seems to be more prevalent on ARM devices.

From that traceback it just looks like however you are comparing the two mappings is considering insertion order or something.

AssertionError: assert <hikari.utili...xffffa41dce50> == {'bash': 'bun...om': 'buebue'}

I'd suggest changing that dict around in order and seeing what happens maybe.

def __eq__(self, other):
    if not isinstance(other, typing.Mapping):  # slow?
        return False
    if len(other) != len(self):
        return False
    for key in self:
        if key not in other:
            return False
    return True

would probably fix this tbf.

from hikari.

https://github.com/python/cpython/blob/3.8/Lib/_collections_abc.py#L685-L687 implies the __eq__ you are deriving is considering if items() == items().

ItemsView does not implement a custom __eq__ by the looks, nor inherit one other than for object.

My suggestion would probably be to either override __eq__ in https://github.com/nekokatt/hikari/blob/master/hikari/utilities/mapping.py#L51 or implement a custom ItemsView, KeysView, ValuesView. First is probably a better thing to do IMHO.

from hikari.