Remove process.exit handles (at least for usage as a module) about node-export-server HOT 3 CLOSED

I agree wholeheartedly. This was cryptically circumventing our unit testing. Get rid of it.

It's also worth noting that returning 0 as the exit code from a global error handler is a pretty bad idea since it gives no indication to any process monitoring it that anything failed.

from node-export-server.

Firstly, sorry for the delay in addressing this.

I agree that it's bad practice.

Unfortunately it's the only way I've found that consistently terminates the Phantom-processes, both on error conditions and on normal exists.

I've added a compromise until a better solution can be found: setting listenToProcessExits to false in the the initPool config object will skip attaching the event listeners to the process.

Beware though that this may lead to zombie processes both if the service crashes, and when it's exited normally.

from node-export-server.

Thanks a lot. This compromise works for me. Looks good.

from node-export-server.