Update ring to support s390x and ppc64el about hickory-dns HOT 12 CLOSED

Do you mean this is a regression, or are you trying to expand platform support? For now, ring 0.17 has been merged on rustls main but there's only an alpha release (which contains a bunch of other API changes).

from hickory-dns.

The point is that ring 0.17 just added support for these platforms, but there's no GA rustls release with ring 0.17 support yet.

from hickory-dns.

Here's an issue discussing performance there: briansmith/ring#1678

s390x and ppc64el are going to be fast enough where the fallback implementations will be fine. They are slow in ring's CI because they're being tested in the QEMU emulator. OpenSSL has assembly language implementations of primitives for those platforms which you can use if you trust that code.

from hickory-dns.

Thank you @briansmith !
All platforms build !

See: https://github.com/hickory-dns/docker/actions/runs/6996995774/job/19033474459

from hickory-dns.

Do you mean this is a regression, or are you trying to expand platform support? For now, ring 0.17 has been merged on rustls main but there's only an alpha release (which contains a bunch of other API changes).

I can not say it's a regression because I did not build multi arch before. More about being full multi platform

from hickory-dns.

An option would be to possibly use OpenSSL on those platforms, though that will disallow all of the rustls use cases, like DoH & DoQ as we currently don't have a non-ring based option for those right now.

That being said, it seems like this should be a request on the ring project, right?

Here's an issue discussing performance there: briansmith/ring#1678

from hickory-dns.

That being said, it seems like this should be a request on the ring project, right?

I searched issues upstream and it seems they fixed everything
We are not up to date so I can not open a request or I will get thrown out 😄
We can re evaluate this when ring is updated.

That's okay not to support both platforms for now, not much users on them.
And if anyone needs a real s390x I have a VM at IBM

from hickory-dns.

@williamdes Can you try the latest version on the main branch? PR #2076 bumped ring to 0.17.

from hickory-dns.

The point is that ring 0.17 just added support for these platforms, but there's no GA rustls release with ring 0.17 support yet.

Rustls 0.21 uses ring 0.17 since 0.21.8; see https://github.com/rustls/rustls/releases/tag/v%2F0.21.8. Since hickory-dns uses Rustls 0.21 then you can cargo update -p rustls and this should give you Rustls 0.21.8 that uses ring 0.17.

from hickory-dns.

You'll probably need to disable DoQ, since Quinn still relies on ring 0.16 for now.

from hickory-dns.

@williamdes Can you try the latest version on the main branch? PR #2076 bumped ring to 0.17.

Thank you for the ping, I will try to do it in some following weeks

from hickory-dns.

I am closing this issue, everything seems to be resolved. The multi arch Docker image is pushed to the hub now 🎉
See: https://github.com/hickory-dns/docker/releases/tag/v0.23.0-1

from hickory-dns.