trust-dns only warns instead of returning Err when it has no nameservers listed in /etc/resolv.conf about hickory-dns HOT 6 OPEN

Do you mean the daemon or one of the libraries? For the daemon, I think it could plausibly still serve other parts of the config even if it was unable to resolve via an upstream resolver?

from hickory-dns.

Oh the rust crate used by Vaultwarden. The issue has more depth on this thread: dani-garcia/vaultwarden#3941 (reply in thread)

[2023-10-02 00:59:53.441][trust_dns_resolver::system_conf::unix][WARN] no nameservers found in config

it is writing a warning to be logged, but it is not throwing an Err so devs are still trying to perform queries with a resolver that has no nameservers.

from hickory-dns.

Ahh, so yes, if you're instantiating a resolver from trust-dns-resolver I definitely agree it makes sense to yield an error for this case. Are you able to submit a PR?

from hickory-dns.

Are you able to submit a PR?

I have honestly never looked at coding in rust in my life. If I knew what I were doing I would.

from hickory-dns.

In saying that, I'm sure I can have a crack at it, as it's just going to be a matter of finding that warning in the code and changing that log write to an exception throw, 5 minutes of google should educate me, I can have a crack at it I guess, assuming it's relatively straight forward to tool up for rust.

from hickory-dns.

@djc I think I have done it, this is the result of me googling how to raise an Err #2043

from hickory-dns.