Comments (2)
I would agree with this, plugins should be cloning the collection to have their own copy, but I know that may not be clear right now for plugin developers and they may attempt to make changes in ways that could hurt HMCC on their servers.
from hmccosmetics.
@LoJoSho Good point, but making CosmeticUser.getCosmetics()
return an ImmutableCollection<Cosmetic>
wouldn't introduce any breaking changes unless someone is modifying the returned clone. We could solve this by listing CosmeticUser.getCosmetics()
as deprecated and making a new method, for example CosmeticUser.getUserCosmetics()
, that returns ImmutableCollection<Cosmetic>
from hmccosmetics.
Related Issues (20)
- [SUGGESTION] possibility to add Cosmetics to NPCS HOT 1
- Multiple Wardrobe Rooms HOT 1
- attached items cloning HOT 1
- [BUG]~Emotes not working on purpur HOT 1
- [SUGGESTION] Small Features for equipped cosmetics HOT 3
- [SUGGESTION] HMC Colors in commands HOT 1
- problem with plugin commands HOT 1
- Texture bug HOT 1
- the default cosmetics do not appear HOT 1
- Cant use modelengine models with Uppercase letters HOT 4
- more events for cosmetics menu
- Purchased Status on cosmetic incorrect
- [SUGGESTION] Auto generate guis // auto sort cosmetics in guis HOT 1
- Shaders (permissions) HOT 1
- [Bug] Cosmetics not hiding immediately upon player-death HOT 1
- New placeholder: Returns the number of cosmetic in a category
- Cosmetics not synced HOT 1
- pages HOT 2
- 1 HOT 1
- Filter system like HMCWraps. HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hmccosmetics.