Code Monkey home page Code Monkey logo

Comments (5)

hgoebl avatar hgoebl commented on May 27, 2024

Hi Viacheslav,
many thanks for the contribution. Sorry, but I haven't worked with AMD yet.
In which environments is AMD used? Server and/or client?
I'm asking because in your solution there is no definition for the .isPhoneSized function.

Do you think some kind of if window or define could solve this problem?

from mobile-detect.js.

hgoebl avatar hgoebl commented on May 27, 2024

I've added some logic so AMD should consider phone-size in browser environments as well.

@unclechu Could you please verify that it's working?

from mobile-detect.js.

unclechu avatar unclechu commented on May 27, 2024

@hgoebl yes, it's works now. But I will change this solution in next pull request, because no need to eval code before it not required. I using it on client side (front-end).

from mobile-detect.js.

unclechu avatar unclechu commented on May 27, 2024

#10

from mobile-detect.js.

hgoebl avatar hgoebl commented on May 27, 2024

Thanks again for your work! It took some time for me to understand the optimization 👍

from mobile-detect.js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.