Code Monkey home page Code Monkey logo

Comments (4)

dey-dey avatar dey-dey commented on May 24, 2024

@hgoebl

from mobile-detect.js.

hgoebl avatar hgoebl commented on May 24, 2024

Thanks for your feedback. You can see mobile() as a short form of phoneOrTablet(). If you are interested in more details you can use phone() and/or tablet().

@daedelus-j do you have a suggestion how to change the API?

And what would you expect when calling mobile()? Returning a falsy value when it's a tablet? A tablet is a mobile device, isn't it?

from mobile-detect.js.

bhamodi avatar bhamodi commented on May 24, 2024

@hgoebl - A tablet is a mobile device, yes. However, for most use cases, tablets are to be treated/rendered differently due to their much larger screen resolutions.

I'd personally recommend differentiating between the two using something like: is_tablet() and is_phone(). Additionally, is_mobile() should yield true for BOTH phones and tablets. 👍

from mobile-detect.js.

hgoebl avatar hgoebl commented on May 24, 2024

@bhamodi that's exactly the case: phone() is truthy for phones, tablet() is truthy for tablets and mobile() is truthy for both. So I don't know what could/should be changed in the existing API.

from mobile-detect.js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.