Comments (15)
@richardgreg assigned 🚀
from hey.
@bigint What images (in what page or location) does this refer to? For images in posts, there is a grey background before the images has loaded, which looks OK in my opinion. On the NFT page for a user, there's already a skeleton loader. Is there some other place that needs skeleton loader?
from hey.
Hi @bigint please assign me to this task :)
from hey.
@bigint please assign me this task for submission. i was the one that did it on dework and you said i should have a PR repo for re submission.
from hey.
@Creed1732 Sure, go ahead and work on it. Though it seems lenster already has the skeleton loader feature. Or am I missing something?
from hey.
yea, they have that already...but not for the images...btw are you a moderator?....
just asking...
from hey.
No, a contributor
from hey.
I already did the task, just waiting to get assigned so i'll make submissions @richardgreg
from hey.
@Creed1732 assigned
from hey.
@bigint check submission
from hey.
@Creed1732 where is the PR?
from hey.
Hi @bigint, had a quick look at this. Which images would we be trying to add a loading shimmer to? As far as I can see, in publications, the PublicationPageShimmer
would cover the whole post including the image in the post and the rest seem to be covered as mentioned here, #59 (comment). Could you please clarify on how this would be handled?
from hey.
I could not find #59 where i was to compare branches
from hey.
is the issue open rn?
would like to work on it
from hey.
This issue has been locked since it has been closed for more than 10 days.
If you found a concrete bug or regression related to it, please open a new bug report.
from hey.
Related Issues (20)
- Not all Smileys/Icons work HOT 2
- Uploading issue using hey HOT 2
- When any picture is opened it blends with the rest of the UI HOT 4
- Local Development: unable to post on testnet HOT 3
- Can not post on Hey HOT 3
- Local development - no way to create a testnet account HOT 2
- Navigation bar is not fixed HOT 4
- Geographical segmentation of views counts on posts leaks users country HOT 4
- Video playback failed HOT 3
- Post link preview displayed incorrectly HOT 1
- Some handle links are rendered as text in posts HOT 2
- Random logouts and unable to log back in unless I clear cookies
- Unable to delete post you have mirrored HOT 2
- Tips are counted as Collects
- Add disable state for follow button when it's not finalized on-chain HOT 1
- Is this open source? HOT 2
- Migrate the composer to Prosekit HOT 7
- Support "Pay What You Want" Collects HOT 15
- Mentions dropdown not getting hidden if we not selecting from the list HOT 3
- Handles with _ not rendering HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hey.