Code Monkey home page Code Monkey logo

Comments (15)

bigint avatar bigint commented on August 28, 2024 1

@richardgreg assigned 🚀

from hey.

foolo avatar foolo commented on August 28, 2024

@bigint What images (in what page or location) does this refer to? For images in posts, there is a grey background before the images has loaded, which looks OK in my opinion. On the NFT page for a user, there's already a skeleton loader. Is there some other place that needs skeleton loader?

from hey.

richardgreg avatar richardgreg commented on August 28, 2024

Hi @bigint please assign me to this task :)

from hey.

Creed1732 avatar Creed1732 commented on August 28, 2024

@bigint please assign me this task for submission. i was the one that did it on dework and you said i should have a PR repo for re submission.

from hey.

richardgreg avatar richardgreg commented on August 28, 2024

@Creed1732 Sure, go ahead and work on it. Though it seems lenster already has the skeleton loader feature. Or am I missing something?

from hey.

Creed1732 avatar Creed1732 commented on August 28, 2024

yea, they have that already...but not for the images...btw are you a moderator?....
just asking...

from hey.

richardgreg avatar richardgreg commented on August 28, 2024

No, a contributor

from hey.

Creed1732 avatar Creed1732 commented on August 28, 2024

I already did the task, just waiting to get assigned so i'll make submissions @richardgreg

from hey.

bigint avatar bigint commented on August 28, 2024

@Creed1732 assigned

from hey.

Creed1732 avatar Creed1732 commented on August 28, 2024

@bigint check submission

from hey.

bigint avatar bigint commented on August 28, 2024

@Creed1732 where is the PR?

from hey.

brymut avatar brymut commented on August 28, 2024

Hi @bigint, had a quick look at this. Which images would we be trying to add a loading shimmer to? As far as I can see, in publications, the PublicationPageShimmer would cover the whole post including the image in the post and the rest seem to be covered as mentioned here, #59 (comment). Could you please clarify on how this would be handled?

from hey.

Creed1732 avatar Creed1732 commented on August 28, 2024

I could not find #59 where i was to compare branches

from hey.

Sahil-B07 avatar Sahil-B07 commented on August 28, 2024

is the issue open rn?
would like to work on it

from hey.

github-actions avatar github-actions commented on August 28, 2024

This issue has been locked since it has been closed for more than 10 days.

If you found a concrete bug or regression related to it, please open a new bug report.

from hey.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.