Code Monkey home page Code Monkey logo

Comments (4)

crhallberg avatar crhallberg commented on June 19, 2024

I agree that it's not as vital as the other elements but having a few widths for containers is really useful for consistency.

What do you think about just a few widths like this? https://www.gethalfmoon.com/docs/containers/. This may make more sense as an extension of --measure.

from pollen.

madeleineostoja avatar madeleineostoja commented on June 19, 2024

Interesting idea of making them responsive. That would be the only value in pollen that changes based on breakpoint so I’m hesitant to introduce complexity, but it’s a cool idea.

And yeah I think I’m leaning towards just removing a bunch of values so it’s at least much simpler.

from pollen.

madeleineostoja avatar madeleineostoja commented on June 19, 2024

This is what I'm thinking atm. Each step roughly correlates to a typical device breakpoint but not semantically tied to devices/breakpoints

/**
  * Container widths
  * Applied as max-width
  */
--width-xs: 480px;
--width-sm: 640px;
--width-md: 768px;
--width-lg: 1024px;
--width-xl: 1280px;

from pollen.

madeleineostoja avatar madeleineostoja commented on June 19, 2024

Closing this, not worth removing width scale, I think having a few device-derived container widths is useful enough to keep in core

from pollen.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.