Comments (7)
Hexagon
commented on September 24, 2024
2
Oh! Will have a look at this as soon as possible. Thanks for a great bug report!
from croner.
buzzinJohnnyBoi
commented on September 24, 2024
1
I sent the PR, wasn't sure if you wanted me to include the changes after running npm run build, so I looked at some of your previous PRs and it looks like you do that sometimes, so I included them :)
from croner.
buzzinJohnnyBoi
commented on September 24, 2024
Hello, @Hexagon, I gave finding the bug a shot, and I think I have fixed it.
In the /src/croner.js file (_next function), I just added a check !prev && options.startAt && options.interval, then calculate when prev (previous run) should have been. I have tested this with multiple different values, and it gets the correct value each time.
All tests and linters pass, and I have run npm run build and the tests for dist pass as well.
I also added a test in /src/suites/options.cjs with the startAt in the past and the excepted date in the future.
Is it OK if I create a PR for this issue?
My Commit
from croner.
Hexagon
commented on September 24, 2024
@buzzinJohnnyBoi Awesome, send the PR 👍
from croner.
Hexagon
commented on September 24, 2024
@buzzinJohnnyBoi's fix available to test through npm i [email protected]
from croner.
CommanderStorm
commented on September 24, 2024
Closing as #248 was merged ^^
Thanks everyone ❤️
from croner.
Hexagon
commented on September 24, 2024
An additional fix by @buzzinJohnnyBoi released through prerelease 8.0.3-dev.1
from croner.
Related Issues (20)
- L5,6 Day of the Week is not working correctly - L is not a number HOT 5
- Croner returns different values in case of trailing whitespace HOT 2
- Race HOT 4
- Fix and add the examples links HOT 1
- Request: Last day minus X HOT 1
- Bug: Increment not work as I expected HOT 3
- Specifying timezone causes no trigger using croner <= 7.x HOT 9
- previousRun and currentRun return null all the time HOT 5
- Using */59 * * * * * make run function twice HOT 1
- Support for modulo operator
- Specific timezones cause high CPU load on UNIX systems using croner <= 7.x HOT 10
- Storing job constant in mongo Db results in error HOT 1
- [Feature Request]: A way to stop all scheduled jobs, but wait for running jobs to complete HOT 2
- Job won't run when scheduled with America/Anchorage time zone HOT 1
- Events Feature request HOT 1
- Allow update HOT 1
- using utcOffset throws error: Invalid time zone specified HOT 2
- nextRun gives wrong result when using L (last day) notation HOT 3
- nextRuns returning wrong values when using 4th day of the Month HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from croner.