firewalls.apply_to_resources makes no sense about hcloud-python HOT 5 CLOSED

Code-Snipped is from https://hcloud-python.readthedocs.io/en/latest/_modules/hcloud/firewalls/client.html#FirewallsClient.apply_to_resources

from hcloud-python.

Hey @uroflavin,

sorry for the late answer!

Basically, you need to use a FirewallResource (hcloud.firewalls.domain.FirewallResource) (as stated in the documentation), not a Server. The FirewallResource is a Wrapper around a Server (currently the only supported resource, but there might be more in the future).

Does this help you @uroflavin?

• Lukas

from hcloud-python.

Sorry, my fault. I should be more precisely.

the documentation name it „rules“, the function named it „resources“ - and now you introduce me to assign a firewall Ressource (which is a server) - to what? a Firewall-ressource ...

my main concern was the documentation, now with your explanation I’m just more confused than before...

My intention was, to get the doc-string fixed. 🙃

from hcloud-python.

Hey @uroflavin,

thank you, I submitted an MR to fix the docstring.

Basically, it is quite easy to use, you can find a sample within out tests: https://github.com/hetznercloud/hcloud-python/blob/master/tests/unit/firewalls/test_client.py#L307 (or for the BoundFirewall: https://github.com/hetznercloud/hcloud-python/blob/master/tests/unit/firewalls/test_client.py#L133)

from hcloud-python.

great work - thank you!

from hcloud-python.