Comments (7)
iOS 11 iPhone 7 I'm still seeing this issue. =( even with isTranslucent set to true. I have a UITabBarController as well.
from hero.
It appears the issue is fixed! Cheers 👍
from hero.
When you disable Hero, does this problem go away? Can you give me two screenshot? One with Hero enabled and one with it disabled
from hero.
Yes, disabling Hero or setting the isTranslucent
property back to true
solves the problem.
I can't provide you comparative screenshots right now, as I'm working with on a project with sensitive data but basically the content of the second view controller appears below the navigation bar.
I'll try and make a demo project ASAP.
from hero.
@Saeros Can you try the latest master? Your problem might be fixed by #60
pod "Hero", :git=>"https://github.com/lkzhao/Hero.git"
from hero.
Thanks @lkzhao I'll give it a go and report back the result.
from hero.
First of all awesome library 👍
I have a tabbar (with 5 tabs) in a navigation controller.
Last view controller of tabbar hides navigationbar.
This causes the last view having a space below the view and the tabbar.
If i disable hero it works without any problems.
Also while hero is active, if a push another view (while last tab is active) and pop back, view displays correctly.
Hero version 1.0.1 - IOS 11.2 + iPhone6+
from hero.
Related Issues (20)
- Animation not working for UICollectionViewDiffableDataSource HOT 1
- Request: Make HeroTransition::complete(after: TimeInterval, finishing: Bool) public
- Version 1.6.2 doesn't work with SPM HOT 16
- <Hero/Hero-Swift.h> file not found when I use “ pod 'Hero' ”.
- Animation doesn't work when navigationController pushing screen HOT 4
- OverFullScreen problem HOT 3
- HeroModifiers will fail when a nested `when` modifier exist
- 在tabbar控制器嵌套的navigation控制器中push进子页面,tabbar的显示/隐藏没有任何动画 HOT 2
- hero push animation is unable to turn off
- How do I keep the tabbar is not hidden when push
- Doesn't the demo project work? HOT 2
- Spring Modifier on dismiss view controller Hero.
- hidesBottomBarWhenPushed bug
- Demo cant be run.
- need help, match hero animation across multiple preseting viewcontollers HOT 1
- Default source code, why is there a black area at the top? HOT 2
- Black screen when removing VC
- CI/CD github action needs update to newer env
- Privacy Manifest HOT 1
- Library not loaded HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hero.