Code Monkey home page Code Monkey logo

Comments (3)

edwardotis avatar edwardotis commented on May 29, 2024

Here's the line that is incorrectly adding default port, and thus breaking all possible providers of memcached on heroku, except for the custom supported memcachier.

manager.setMemcachedNodes(System.getenv("MEMCACHE_SERVERS") + ":11211");

https://github.com/jsimone/webapp-runner/blob/df41b59e1bb36755ed614809b6ad6a235465100a/src/main/java/webapp/runner/launch/MemcacheSessionStore.java#L25

In fact, all the code around parsing MEMCACHE_SERVERS is broken. It fails to support multiple memcached servers, and thus breaks the contract with the underlying memached session library.

from webapp-runner.

jkutner avatar jkutner commented on May 29, 2024

I will gladly accept a PR for that. Looks like it should probably work like the MEMCACHIER_SERVERS env var.

from webapp-runner.

Malax avatar Malax commented on May 29, 2024

Hello! Since this is an old issue and many things have changed since it was opened I will close it for now. Feel absolutely free to re-open it if it is still relevant so we can work on it! :)

from webapp-runner.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.