Code Monkey home page Code Monkey logo

Comments (3)

zyro avatar zyro commented on August 24, 2024 1

I think you're right and it is more readable, but not enough to be worth breaking backwards compatibility. We'll have to revisit this for Nakama 4.x. 👍

from nakama-common.

zyro avatar zyro commented on August 24, 2024

@smhmayboudi Thanks for the report, but it would help if you added some context. Why should this change be made, and what is the impact?

from nakama-common.

smhmayboudi avatar smhmayboudi commented on August 24, 2024

I think it becomes more readable like the following line after it:

nakama-common/runtime/runtime.go

Line 996 in 036a5bd

WalletsUpdate(ctx context.Context, updates []*WalletUpdate, updateLedger bool) ([]*WalletUpdateResult, error)

and I changed it to the new one.

walletUpdate(ctx context.Context, update *WalletUpdate, updateLedger bool) (*WalletUpdateResult, error)

from nakama-common.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.