Code Monkey home page Code Monkey logo

Comments (5)

JamesMcMahon avatar JamesMcMahon commented on June 14, 2024 1

Hey! Happy to test it out, will try and get to it this weekend.

from heroicgameslauncher.

imLinguin avatar imLinguin commented on June 14, 2024

Does this happen only when you go through game pages while the library is being refreshed?

Many requests to gamesdb during the library refresh are to be expected, though they should re-use the HTTP connection, so there shouldn't be any additional DNS queries. Believe it or not this is how GOG designed that API.

from heroicgameslauncher.

JamesMcMahon avatar JamesMcMahon commented on June 14, 2024

Does this happen only when you go through game pages while the library is being refreshed?

I feel like this has happened occasionally when I just boot the app and have zero user input but it seems to more reliably happen when I click a game after boot.

For reference I have 400 games in my GOG library so it's rather large. I am not sure if each game gets it on HTTP request response cycle and that if the number of calls is unbounded based on the library size / other factors.

from heroicgameslauncher.

JamesMcMahon avatar JamesMcMahon commented on June 14, 2024

I have since double my flood protection limit to 2,000 requests over 60 seconds and this still happens. It's pretty crazy even with the default of 1,000, I've never seen any program on Windows, MacOS or Linux trigger for the 6 or so years I've run a pihole on my local network.

image

I'd be curious to see if this effects other folks as well or it's something local to my setup.

from heroicgameslauncher.

imLinguin avatar imLinguin commented on June 14, 2024

@JamesMcMahon could you try the build from Pull request linked above? I think this should fix DNS flooding problem. Thanks for bringing this to our attention, somehow for the time we had this method of importing games no one really noticed the problem

from heroicgameslauncher.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.