Comments (1)
Following up on this: we came across this from a test in hera_sim
failing. I looked into the issue, and my understanding is that this error will only ever crop up when trying to apply BDA to a data set that doesn't actually need BDA applied to it. I can think of two ways to address this:
- Assume that analysts using this are sensible and will not apply BDA to data that doesn't need BDA applied to it, and so don't update the code.
- Make
apply_bda
a little dummy proof by protecting this in a try-except clause, maybe like so:
try:
uv2.phase_center_ra = zenith_ra.rad
uv2.phase_center_dec = zenith_dec.rad
uv2.phase_type = "phased"
...
except UnboundLocalError: # no bda was applied
uv2.phase_type = uv.phase_type
uv2.phase_center_ra = uv.phase_center_ra
...
I don't understand the process well enough to know whether this is possible, but I suppose a third option would be to add an additional check at the beginning of the routine (with all the other checks that are run, before the uv2
object is created) to see if it even makes sense to apply BDA to the input uv
, and just return uv.copy()
if it doesn't make sense to apply BDA.
from baseline_dependent_averaging.
Related Issues (3)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from baseline_dependent_averaging.