`helmfile sync --interactive` does not ask for confirmation before applying about helmfile HOT 9 CLOSED

@WoodyWoodsta PR is welcome.

from helmfile.

@WoodyWoodsta From the code. In sync subcommand, no logic for interactive.

from helmfile.

Ok thanks for the investigation. This seems like a fairly consequential missing feature, and at the least quite misleading documentation. The sync command can be considered a dangerous command with respect to an entire cluster, so reading in --help that interactive will confirm before making changes to the cluster as a global flag makes it appear as though it will behave the way I expected.

Which commands does --interactive apply to?

from helmfile.

@WoodyWoodsta I will try to add it in sync. wait my PR or your PR. haha

from helmfile.

Thanks @yxxhero - if I get some time I can have a quick look but I work full-time, so we'll see 😄

from helmfile.

@WoodyWoodsta OpenSource requires all of us.

from helmfile.

Hey! Thanks for reporting and investigating.
Probably this was an unintended regression introduced when we migrated our CLI framework from urfave/cli to cobra?
Just to be clear, the point of --interactive was to let Helmfile ask AFTER showing the diff and BEFORE actually applying the changes.
So, from the author's perspective, I can say it's working as intended.
Please use helmfile apply if you need interactivity!

from helmfile.

And we might be adding support for sync and delete as well via #328

from helmfile.

@mumoshu Thanks - explained that way I now understand that apply is a "superset" command including diff and sync, and that --interactive is to ask for confirmation before those two steps. Coming from kubectl apply and helm upgrade, I assumed sync to be more of the latter (which does a diff internally).

from helmfile.