helmfile `jsonPatches` does not work with packaged (e.g. tgz) charts about helmfile HOT 15 CLOSED

Bumping for activity. This is a bug. not an enhancement, unless the jsonPatches functionality is not officially a released feature. If it doesn't work with the large majority of packages, then it's a bug.

from helmfile.

@mumoshu sure.

from helmfile.

Thanks! I'll write up an issue to announce the potential move in the chartify repo.

BTW, https://github.com/variantdev/chartify/releases/tag/v0.11.0 includes the fix for this issue.

from helmfile.

@mumoshu just do it. Thanks very much.

from helmfile.

@seanorama PR is welcome. Thanks very much.

from helmfile.

@yxxhero I' not even sure what the bug is. I'm assuming it's something in chartify.

from helmfile.

@yxxhero Thanks for updating. This is a bug not an enhancement.

from helmfile.

@seanorama OK. PR is welcome.

from helmfile.

Thanks for reporting!
To be clear, Helmfile uses https://github.com/variantdev/chartify under the food for this feature, and perhaps I've never added proper support for patching the archived chart.
That said, although perhaps it's safe to say this is an enhancement rather than a bug, this should be prioritized higher than other feature requests as this is very annoying and can make jsonPatches totally unusable depending on the situation.

from helmfile.

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

from helmfile.

It does work with non tgz charts, like your local that backed by a local directory or a remote chart stored in any remote chart repository. It's a bug. But it isn't true at all to say that it doesn't work with the large majority of packages.

from helmfile.

This is where chartify composes the kustomization.yaml path: https://github.com/variantdev/chartify/blob/acafe90d99962ac9e2464ffc88db2200129a9631/patch.go#L156

So the issue would be coming from a potential bug where the tempDir variable is messed with when you specified a tgz path as the chart. I'm still unsure which line of code is causing that though.

from helmfile.

helmfile/chartify#38 seems to fix the issue at least when tested directly with chartify.

from helmfile.

does https://github.com/variantdev/chartify will move to helmfile org? @mumoshu

from helmfile.

@yxxhero Assuming helmfile is the only and biggest library user, I'm willing to do so! Would you be willing to maintain it with me once moved?

from helmfile.