Code Monkey home page Code Monkey logo

Comments (3)

jnummelin avatar jnummelin commented on June 23, 2024

plus one on this one

We also use Helm as library in our project and having to "inline" the retryingRoundTripper would be unwanted.

from helm.

gjenkins8 avatar gjenkins8 commented on June 23, 2024

Thinking out aloud -- would it make more sense to expose a public helper in https://github.com/kubernetes/cli-runtime ?

Agree, that if this code might provide utility across multiple projects, then it could be made public. But I think that the Helm repo is probably not the best place to expose generic Kubernetes code from. Thoughts?

from helm.

jnummelin avatar jnummelin commented on June 23, 2024

In our case we use helm functionality as a library. That means we have to construct the actions client separately and thus we cannot easily use the roundtripper as it's private. We did find a workaround to get it but it's not really pretty. I'd rather have used it directly. https://github.com/k0sproject/k0s/pull/4515/files

from helm.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.