Code Monkey home page Code Monkey logo

Comments (12)

mattfarina avatar mattfarina commented on September 25, 2024 1

3.15.1 is out and it contains the proper version. Problem fixed.

from helm.

yxxhero avatar yxxhero commented on September 25, 2024

@mattfarina could you take an review? thanks so much.

from helm.

sabre1041 avatar sabre1041 commented on September 25, 2024

Confirmed, seeing the same on the darwin arm64 artifacts

from helm.

erik-bershel avatar erik-bershel commented on September 25, 2024

We've temporary pinned 3.14.4 for GitHub Actions / Azure DevOps. Please drop a confirmation that it's expected behaviour for us to unlock updates of Helm. Thanks in advance.

from helm.

mattfarina avatar mattfarina commented on September 25, 2024

This is interesting because the both tags point to the same commit. When this was created, the release tag was added and CI did the build. So, how do we get CI to handle the tags properly?

from helm.

mattfarina avatar mattfarina commented on September 25, 2024

If I look at the build-cross make target the version comes from ...

git describe --tags --abbrev=0 --exact-match 2>/dev/null

When I run this in Linux environments, I get the release version. I'm not able to duplicate it.

But, the wrong version shows up in the release job and the release job checkout out the exact right tag.

We need to update the build job (GHA workflow) to make sure the VERSION environment variable is the tag, I think?

from helm.

yxxhero avatar yxxhero commented on September 25, 2024

@mattfarina maybe we can rerelease?

from helm.

jack1902 avatar jack1902 commented on September 25, 2024

Encountered this due to ansible within its helm modules throwing a LooseVersion error, downgraded to an older version of helm which reports 3.x.x and things are happy again. The -rc.2 didn't play nicely within Ansible, would be great to address this (through homebrew i don't encounter this -rc.2 issue and get 3.15.0)

from helm.

TheMeier avatar TheMeier commented on September 25, 2024

Uhm isn't that even worse that homebrew ships a different binary?

from helm.

robertsirc avatar robertsirc commented on September 25, 2024

@TheMeier this isn't unusual in open source.

from helm.

mattfarina avatar mattfarina commented on September 25, 2024

@TheMeier open source is about the source code rather than the builds. For example, pretty much everyone uses curl. The curl projects does not distribute binaries. Everyone gets them from their OS, package manager, etc. It's not just acceptable but expected to have different builds of the same source.

from helm.

mattfarina avatar mattfarina commented on September 25, 2024

The pull request at #13059 provides a simple fix. The tag is passed in as the explicit version rather than being automatically detected.

from helm.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.