Invalid values.schema.json passes lint about helm HOT 4 OPEN

Are you able to provide a minimal example we can use to reproduce? I using a default chart generated using helm create and then used helm-schema to generate the json schema. After injecting some extra curly braces in several places, helm lint fails cause the json schema is invalid

from helm.

Hello, indeed I forgot the example 🤦
I ran helm create foobar and then injected this values.schema.json:

{
    "type": "object",
    "required": [
        "image"
    ],
    "properties": {
        "image": {
            "type": "object",
            "required": [
                "repository",
                "pullPolicy"
            ],
            "properties": {
                "repository": {
                    "type": "string",
                    "pattern": "^([-_/.a-z0-9]+)$"
                },
                "pullPolicy": {
                    "type": "string",
                    "pattern": "^(Always|Never|IfNotPresent)$"
                }
            }}
        }
    }
}

You can see the double curly brace after pullPolicy, which makes the json invalid. However, helm lint is happy:

╰ helm lint . -f values.yaml
==> Linting .
[INFO] Chart.yaml: icon is recommended

1 chart(s) linted, 0 chart(s) failed

helm template likely uses the same code path so it's happy as well.

We found out we broke our json thanks to helm package:

╰ helm package .                         
Error: failed to save: Invalid JSON in values.schema.json

I think we can expect lint+template to fail like package does 😄 For example, our CI lints on dev branches but packages only on release/pre-release

Thanks for your help 🙏

from helm.

I managed to reproduce the error as well. This is a valid issue

from helm.