Comments (3)
Can you show the Service objects the chart is creating for the 1.1 and 1.4 releases please.
It is confusing to me why Helm stored e.g the ClusterIP in the 1.4 release manifest. Helm should only be storing the object as rendered by the chart. Unless the chart specified all these fields. Which also is confusing to me as I didn't think Kubernetes allowed changing the ClusterIP (from a client) once created.
Do you see the same on a modern version of Kubernetes?
from helm.
@gjenkins8
In the chart template of openkruise, the definition of Service kruise-webhook-service
is as follows:
{{- define "webhookServiceSpec" -}}
{{- $service := lookup "v1" "Service" .Values.installation.namespace "kruise-webhook-service" -}}
{{- if $service -}}
{{ if $service.spec.clusterIP -}}
clusterIP: {{ $service.spec.clusterIP }}
{{- end }}
{{ if $service.spec.clusterIPs -}}
clusterIPs:
{{ $service.spec.clusterIPs }}
{{- end }}
{{ if $service.spec.ipFamilyPolicy -}}
ipFamilyPolicy: {{ $service.spec.ipFamilyPolicy }}
{{- end }}
{{ if $service.spec.ipFamilies -}}
ipFamilies:
{{ $service.spec.ipFamilies }}
{{- end }}
{{ if $service.spec.type -}}
type: {{ $service.spec.type }}
{{- end }}
{{ if $service.spec.ipFamily -}}
ipFamily: {{ $service.spec.ipFamily }}
{{- end }}
{{- end -}}
ports:
- port: 443
targetPort: {{ .Values.manager.webhook.port }}
selector:
control-plane: controller-manager
{{- end -}}
Pay attention here:{{- $service := lookup "v1" "Service" .Values.installation.namespace "kruise-webhook-service" -}}
The lookup
will find the currently existing kruise-webhook-service
from the cluster and populate its properties into the template.
So the following happened:
- On first deployment,
kruise-webhook-service
does not exist in the cluster, so the ClusterIP is not populated. - On the n-th(n>1) release,
kruise-webhook-service
already exists in the cluster, so the ClusterIP is populated into the template.
In kubernetes1.28, helm sent the same patch:
{
"spec": {
"clusterIP": null,
"clusterIPs": null,
"ipFamilies": null,
"ipFamilyPolicy": null,
"type": null
}
}
but no error is returned.
from helm.
I have found that this is a known Kubernetes bug(in 1.21.X): kubernetes/kubernetes#91459 (comment), and has been fixed in version 1.22.0-beta.2:https://github.com/kubernetes/kubernetes/pull/103532/files.
So, let's close this issue.
from helm.
Related Issues (20)
- Provide methods to disable OCI feature HOT 5
- In Helm 3.9, Default Values Were Used for Subcharts, But Helm 3.15 Raises Nil Pointer Error When Accessing Unset Values HOT 1
- wrong kubeversion detected HOT 6
- RFE: Support for multi-document values files HOT 7
- Warnings: Use tokens from the TokenRequest API or manually created secret-based tokens instead of auto-generated secret-based tokens. HOT 2
- Get more debug informations about why and upgrade failed with "release: already exists" HOT 2
- helm no strict version checking for dependencies
- templating is slower when using dependencies with tagged version HOT 2
- Concurrent `helm dependency build` fail due to race condition
- bug: go HTTPS_PROXY/NO_PROXY env vars are not respected when mTLS args specified on `helm install/upgrade`
- How to properly mock Helm calls ?
- Plan to introduce a dedicated HELM_PROXY_URL environment variable and --proxy HOT 4
- Bug: Using RunWithContext leaks go routines in Wait/WaitWithJobs HOT 2
- Helm panics with an unknown storage driver
- Custom burst limit settings don't apply to discovery
- Enable OpenSSF Scorecard to enhance security practices across the project
- Keda ScaledObject not updated at helm upgrade
- Helm lint exlusion list
- helm dependency can wait other helm release install success, again install next helm release
- Update package go to version 1.22.4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from helm.