Code Monkey home page Code Monkey logo

Comments (6)

unguiculus avatar unguiculus commented on May 18, 2024 1

I assume this is the repo: https://github.com/monotek/helm-charts

Give this is a repo that's supposed to be added to the hub, I'd say it would make sense to test charts before they make it to master.

from chart-testing.

auhlig avatar auhlig commented on May 18, 2024 1

I agree that it would be quite useful to not only diff to HEAD but to a configurable commit passed via a flag:
Tested and valid helm charts live on the master branch and changes can only be done by opening a PR and ensuring the helm chart tests pass.
After merging the PR I want to git diff .. with the previous commit HEAD~1 to be able to detect the changes, test again and finally push the chart to a helm repository.

from chart-testing.

unguiculus avatar unguiculus commented on May 18, 2024

Coud your explain your workflow? Generally speaking, this tool is meant to test changes against a target branch before they are merged. In your case, the chart already seems to be on the target branch. Why is this? Can you elaborate?

from chart-testing.

monotek avatar monotek commented on May 18, 2024

I've pushed directly to master without using a pr but still wanted the travis ci pipline to do the tests...

from chart-testing.

monotek avatar monotek commented on May 18, 2024

Yes, of course. The repo was more or less a test to copy the old helm/stable repo workflow without the need to have own infrastructure. At the end i wanted to have the repo on Github pages (https://monotek.github.io/charts/index.yaml via https://github.com/monotek/monotek.github.io ) and the upload to that repo should be triggered after succesful test in https://github.com/monotek/helm-charts.

from chart-testing.

kyschouv avatar kyschouv commented on May 18, 2024

This would be useful. We were able to work around it by setting target-branch to master^ if we detected that HEAD and origin/master (our remote and target branch) were the same commit hash (and that there were no diffs in the files).

from chart-testing.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.