Code Monkey home page Code Monkey logo

Comments (6)

jlegrone avatar jlegrone commented on May 22, 2024

I'm thinking this might also make it easier to support using ct as a helm plugin at some point.

from chart-testing.

lsowen avatar lsowen commented on May 22, 2024

@jlegrone I was just dealing with this. Do you know this historical reasons behind why change detection is disabled when using --charts?

from chart-testing.

jlegrone avatar jlegrone commented on May 22, 2024

@lsowen I'm not 100% on this but I think the use case was for singling out specific charts for testing in the large community charts repo. That can still be accomplished after this proposed change by configuring ct to not discover charts from parent directories, eg: --charts stable/redis for a specific chart, or --chart-dirs stable,incubator for all charts.

from chart-testing.

unguiculus avatar unguiculus commented on May 22, 2024

@jlegrone Not sure what you mean with old behavior with --charts ./somechart --all.

It doesn't make sense to use these flags together. --charts tests specific charts while --all tests all charts. In these cases, no Git logic is involved, i. e. there is not change detection. These flags are meant to test charts unconditionally. Thus, there can be no version bump checking. It seems this is not clear.

from chart-testing.

github-actions avatar github-actions commented on May 22, 2024

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

from chart-testing.

github-actions avatar github-actions commented on May 22, 2024

This issue was closed because it has been stalled for 5 days with no activity.

from chart-testing.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.