Batch FileDone event to avoid websocket flood about zeronet HOT 6 CLOSED

• queue for websocket messages

from zeronet.

Would async managing this be able to help? Or is it because the greenlets are trying to attach to the same socket?

from zeronet.

It happened when i ran the zeronet on remote machine (around ~40ms away) and downloaded a site with many small files.
The ZeroNet pushes pushes an event over websocket after every file download, and maybe the last event message was still not finished when the next came.
I think it could be fixed like this:

def send(message):
 self.message_queue.append(message)
 if not self.sending:
    self.sending = True
    while self.message_queue:
      self.socket.send(self.message_queue.pop(0))
    self.sending = False

Maybe there is a better solution with gevent, but i like pure-python solutions, its easier to understand whats really happening.
Btw I optimized the Websocket to much smaller event messages, maybe its not an issue anymore, im going to test it later.

from zeronet.

The gevent queue is as understandable as a straight python implemented queue and it seems easy to use.

http://www.gevent.org/gevent.queue.html

one example they use at the bottom:

def worker():
    while True:
        item = q.get()
        try:
            do_work(item)
        finally:
            q.task_done()

q = JoinableQueue()
for i in range(num_worker_threads):
     gevent.spawn(worker)

for item in source():
    q.put(item)

q.join()  # block until all tasks are done

from zeronet.

I think this model will not work in this case, because we dont want to send messages in parallel and we dont want to wait until the message is sent

from zeronet.

ran into this problem again, so i fixed it:

from zeronet.