Comments (2)
I'm not too concerned with how changes here interact with the builtin actors runtime, I'm more concerned with how changes to this library might impact downstream users.
Specifically, I want to make sure that improvements to the abstractions in this library actually improve the usability of these abstractions in practice. Toy examples in this library will help, but the only sure-fire way to validate usability is to try out changes in the builtin-actors repo (for the moment, at least).
For example, the change where Token::wrap
started taking the ActorRuntime
by reference instead of by-value snuck into #190 but ended up causing a somewhat painful migration downstream because the ActorRuntime
now needed a place to live on the stack.
Basically, I'm asking for something exploratory. Before merging a PR with significant API changes:
- Checkout a copy of the builtin actors.
- Patch in the change to this library.
- Try fixing any compilation errors.
from filecoin.
I think we're saying a similar thing? The built-in actors are a downstream user. My proposal aims to detect something like that ActorRuntime-needs-the-stack issue earlier by having it emerge in code in this repo, which is much quicker to discover and so a better design environment. I'm not saying we should never also try an actual integration, but we can make it less part of tight dev cycle.s
from filecoin.
Related Issues (20)
- Remove Cbor trait from exported types
- Benchmark representation of Vec<TokenID> HOT 1
- Make NFT state - layer dumber HOT 2
- Decide if return values should include the list of token_ids HOT 1
- Set new owner outside of loop
- Allow account-level operators to set approval for tokens
- Explicit from param in hooks/burning
- Investigate if result_large_err needs fixing HOT 1
- checking this outside requires an extra load (same for transfer_from)
- FRC46: MintReturn etc. should use Option<IpldBlock> for optional data HOT 2
- Run package releases off CI HOT 1
- Update AMT / HAMT libraries to allow for ranged iteration HOT 4
- Optimise allowance data into same HAMT as balances
- Release coordination with FM and built-in actors HOT 2
- Add types for one-value params and returns
- Switch to stable rust toolchain HOT 1
- `frc42_macros` indirectly depends on `fvm_sdk` and `fvm_shared` HOT 1
- Refactor integration tests
- [Proposal] Move `helix-onchain/filecoin` to `filecoin-project` org HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from filecoin.