crash when opening repo with V3 pack files about helix HOT 4 OPEN

Yes, I agree! I will see to add support for whatever that is - it's not pack V3 I think as that would fail gracefully elsewhere. It's surprising that older Git can handle this in a fashion that doesn't involve dying.

from helix.

Is there anything special about the git repository used in this project? From the backtrace it looks like gitoxide is having trouble parsing some of the git data

from helix.

CC @Byron

I think this is related to the sha-256 transisition. Maybe some new git versions now generate v3 pack files? It would be nice to support them but if gix can't do that for now not panicking and just emitting an error would be good.

from helix.

I have looked into this and couldn't find evidence of a new pack-entry type in the Git codebase.

It also looks like that Git will never write packs that aren't V2 - initially I thought it might write V3 based on some other criteria.

It seems what Git would do in this case is to mark the object as bad and fail to decode it. Now gitoxide will fail gracefully here, but it will probably mean that some operations that rely on this object will fail, but it's better than panicking.

from helix.