Code Monkey home page Code Monkey logo

Comments (4)

mjradwin avatar mjradwin commented on August 27, 2024 1

Agreed - the problem was indeed exactly as you describe. I've implemented a fix and have published new npm package @hebcal/[email protected]. I will deploy to the website tomorrow.

from hebcal-es6.

mjradwin avatar mjradwin commented on August 27, 2024

Thanks. We will do some investigation. We are using the solar-calc JavaScript library, and you have provided helpful guidance.

from hebcal-es6.

sdubois avatar sdubois commented on August 27, 2024

Started taking a closer look into the solar-calc library and I think this issue is arising from a bug in how it calculates the Julian date. Here are some examples from Dec 31 2020 to Mar 2 2021.

Dec 31 2459214.5
Jan 01 2459213.5
Feb 27 2459269.5
Feb 28 2459270.5
Mar 1  2459274.5
Mar 2  2459275.5

When you compare these dates to the dates provided by an online conversion tool such as https://www.onlineconversion.com/julian_date.htm you can see that everything from Jan 1 to Feb 28 is incorrect.

from hebcal-es6.

mjradwin avatar mjradwin commented on August 27, 2024

Changes deployed.

https://www.hebcal.com/zmanim?cfg=json&start=2021-02-27&end=2021-03-02&geo=zip&zip=07666

Closing this bug. Some URLs may be cached for up to 30 days so if you find something that looks wrong, check the Age HTTP header.

from hebcal-es6.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.