Comments (3)
Feel free to give this branch a go. It switches out the thread for a GCD queue.
https://github.com/heardrwt/RHAddressBook/tree/gcd-thread-safety
from rhaddressbook.
Ok, I'll give it a try whenever I get a chance. Took a look at the GCD branch real quick and kind of worried about all the use of dispatch_sync though. I think a better way of managing concurrency is to follow FMDB's style. Assume single-threaded access but providing optional capability to synchronize concurrent access.
Meanwhile by the way, i was able to get a performance speedup of 2x by batching operations together to perform on the address book thread.
[book performAddressBookAction:^(ABAddressBookRef addressBookRef) {
NSArray *people = [book peopleOrderedByUsersPreference];
for (RHPerson *person in people) {
person.firstName;
person.lastName;
person.phoneNumbers;
person.emails;
}
NSTimeInterval taken = [[NSDate date] timeIntervalSinceDate:date];
NSLog(@"rhaddressbook took %f seconds %ld", taken, (long)people.count);
} waitUntilDone:NO];
Logs
2013-10-20 12:43:20.061 [830:60b] abaddressbook took 0.034871 seconds 779
2013-10-20 12:43:20.279 [830:6b0b] rhaddressbook took 0.217319 seconds 779
from rhaddressbook.
GCD branch is now on master.
from rhaddressbook.
Related Issues (20)
- Crash in NSThread+RHBlockAdditions.h HOT 1
- Failed to create RHAddressBookSharedServices instance
- 3-5 Seconds to initialize HOT 1
- implicit conversion
- Localized address format? HOT 1
- New RHPerson in Local addressbook when default is Icloud ?
- Not receiving Notifications in swift
- Native Swift version
- Compile issues with latest source HOT 2
- Update version in Cocoapods repository to 1.2.0 HOT 1
- Why RHAddressBook/AddressBook.h file not find?
- [RHPerson vCardRepresentationForPeople:] crash
- Crash in RHAddressBook vCardRepresentationForPeople
- Xcode 6.3 reports semantic issues HOT 1
- application blocks when i click one group in tableview
- Does RHPerson support NSCoing? How can I NSCoding RHPerson?
- RHRecord crash HOT 3
- import for Swift? HOT 1
- Update the example & README for non-ARC version?
- How can I get google id (social type id)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rhaddressbook.