Disable geocoding support without needing to edit RHAddressBook.h about rhaddressbook HOT 12 CLOSED

Good point. I should likely wrap my #define in an #ifndef.

#ifndef RH_AB_INCLUDE_GEOCODING
#define RH_AB_INCLUDE_GEOCODING 1
#endif

from rhaddressbook.

Yeah, I tried wrapping the #define in an #ifndef but that didn't work, I think because the library is built before my project is (and thus RHAddressBook.h's #ifndef would be evaluated before my #define in my prefix header).

from rhaddressbook.

I pushed commit 0f5b9e8
You might have better luck passing RH_AB_INCLUDE_GEOCODING=0 in Preprocessor Macros (GCC_PREPROCESSOR_DEFINITIONS).

from rhaddressbook.

I tried that too, but it did not work.

from rhaddressbook.

Are you including RHAB as a sub-project?

from rhaddressbook.

Yes, I followed the instructions at http://rheard.com/blog/using-static-ios-libraries/ to set it up.

from rhaddressbook.

This is the only reference i can find to being able to pass flags to sub-projects directly.
ie using xcodebuild directly.
http://www.cocoabuilder.com/archive/xcode/299246-can-pass-some-value-to-sub-project.html

from rhaddressbook.

Easiest option is likely forking.

from rhaddressbook.

But you could setup a run script phase to build the sub-project using xcodebuild with a custom configuration file that overrides GCC_PREPROCESSOR_DEFINITIONS to include RH_AB_INCLUDE_GEOCODING=0

from rhaddressbook.

Gotcha, thanks for looking into it!

from rhaddressbook.

Shouldn't this be a run-time feature? Why use compile time macro for enabling / disabling?

from rhaddressbook.

The main problem with current way of supporting geocoding is that it's super slow if there are a large number of contacts.

from rhaddressbook.