POST_Links does not return link information when following links recursively about hsds HOT 5 CLOSED

Spoke to John about this - follow_links should return all links that match the name in the provided groups. Limit and CreateOrder are used in the case where titles is not provided, so they should stay. marker isn't actually checked for by POST_Links, so no change is needed there.

from hsds.

@jreadey I'm not sure I understand how this endpoint is supposed to work with the pattern parameter. testGetPattern expects group ids to be returned that don't contain any links that fit the pattern. Is it meant to return all searched group ids (empty or not) when using a pattern, and not without a pattern?

Here's the (expected) response in testGetPattern with empty groups:

{'links': 
   {'g-f81913f9-909037d3-7091-9b7118-18bf5b': [], 
   'g-f81913f9-909037d3-0b41-8c15a0-ba4fad': [], 
   'g-f81913f9-909037d3-2304-9163c1-15d503': [
      {'id': 'd-f81913f9-909037d3-cd25-bd6a92-8700e7', 'class': 'H5L_TYPE_HARD', 'created': 1707845214.4165003, 'title': 'dset2.1'}, 
      {'id': 'd-f81913f9-909037d3-be98-2bdfa6-91fa48', 'class': 'H5L_TYPE_HARD', 'created': 1707845214.4451396, 'title': 'dset2.2'}
   ],
    'g-f81913f9-909037d3-f6a8-00d8e6-4046b6': [
      {'id': 'd-f81913f9-909037d3-39d1-9c7ecc-a8b46b', 'class': 'H5L_TYPE_HARD', 'created': 1707845214.270042, 'title': 'dset1.1.1'}, 
      {'id': 'd-f81913f9-909037d3-697f-a976fe-b8c909', 'class': 'H5L_TYPE_HARD', 'created': 1707845214.2981899, 'title': 'dset1.1.2'}
   ], 
   'g-f81913f9-909037d3-6cba-d68216-f3d0b1': [], 
   'g-f81913f9-909037d3-cc63-497daf-2bf556': []
   }
}

from hsds.

Yes, that is the intent. You could make the case to not return group ids that contain no links, but I like the explicit empty list.

from hsds.

I tried out titles with follow_links and it doesn't return a sensible result -- links to subgroups won't get followed if the subgroup link is not in titles. Rather than fix this up, I think it makes more sense to return a 400 if titles is used with follow_links -- I've submitted a PR for this change. The PR also raises 400 if CreateOrder is used with titles or Limit is used with titles.

from hsds.

Resolved in #314

from hsds.