Code Monkey home page Code Monkey logo

Comments (22)

hawkeye-stan avatar hawkeye-stan commented on July 30, 2024 2

Hi all,

I think I've found the culprit of the problem. I believe the issue is the base pop out window title bar in Windows OS. In windows 10 or 11, I'm guessing with different windows theme or different window scale, the pop out window title bar (in Red) has much taller height than I expected. This in turn affect the calculation for MSFS instrumentation pop out title bar height (in Orange) which I used to determine the relative location of "magnifying glass" icon to click. I've changed the algorithm in how I get the MSFS instrumentation title bar height and it seems to make my calculation much more accurate.

image

Since I'm not able to reproduce your issues on my Windows 11 machine, I need your help and hope the following beta build will fix your issue. Please download the following zip file and unzip the exe in your installation folder and overwrite your v3.4.3 exe. All your settings and profile will not be affected. Also, if this works for you, you can continue using this version until I do an official v3.4.4 release and the app will automatically update for you at that time for any new additional feature.

https://github.com/hawkeye-stan/debug-and-support/releases/download/POPM-PopOutSeparationFix/MSFSPopoutPanelManager-beta-issue40.zip

If this fix does not work, you can revert back to v3.4.3 version by redownloading it from the release section in this repo and I'll go back to drawing board and see what else could be causing the problem.

Stanley

from msfs-popout-panel-manager.

Delta-Charlie-DEV avatar Delta-Charlie-DEV commented on July 30, 2024 1

Hi Stanley,

looks good !! Seems to work for me. I'll have to do more tests to be sure, but I tried two flight starts, and the popout process was fine both. Many thanks !

from msfs-popout-panel-manager.

hawkeye-stan avatar hawkeye-stan commented on July 30, 2024 1

Glad the fix seems to be working!

As for pop out FPS drop, running the game with DX12 have no FPS penalty but if you're using Nvidia GPU, quite a few users have reported issue that the performance is not stable with current Nvidia driver in SU10. They're waiting for new GPU driver release in the next few days. As for AMD GPU which I have, DX12 runs almost as good as DX11 other than high VRAM usage in certain built-up area which could cause FPS drop. But when I need to fly VFR in the country or use pop out for an aircraft, I'll run the game in DX12.

from msfs-popout-panel-manager.

hawkeye-stan avatar hawkeye-stan commented on July 30, 2024 1

I've an AMD 5700XT with 8gb of VRAM running the game in 1440p.

from msfs-popout-panel-manager.

hawkeye-stan avatar hawkeye-stan commented on July 30, 2024 1

This fix will officially integrate into upcoming release 3.4.4

from msfs-popout-panel-manager.

hawkeye-stan avatar hawkeye-stan commented on July 30, 2024

Hi Narvik-Ramius,

I sorry that you're having an issue with the latest version 3.4.3. I tried to reproduce your issue on a standard A320 and FlyByWire A320 but was unable to reproduce it. Unfortunately, I don't have FENIX A320 to test with and I'm not sure what could be causing your issue at the moment.

You can roll back to previous version of the application by downloading release v3.4.2 and just replace "MSFSPopoutPanelManager.exe" in the installation folder. When you start the app and is asked to update, just click skip update.

https://github.com/hawkeye-stan/msfs-popout-panel-manager/releases/tag/v3.4.2

In the mean time, I'll dive into my code and see what could be causing your issue and I will also report back if I receive similar report from other users.

Stanley

from msfs-popout-panel-manager.

hawkeye-stan avatar hawkeye-stan commented on July 30, 2024

Hi Narvik-Ramius,

After looking at my code, the only change in my app that could be causing your issue is I've updated the UI to display the number circle momentarily before a panel is being popped out. I'm guessing in your case, the number circle display somehow is blocking the actual Right Alt / Left Click keystroke to pop out the panel. I've added a small delay between the number circle display and the actual sending of the pop out keystroke and it may fix your issue. If you don't mind, please download the following test release build "msfs-popout-panel-manager-fenix-a320-fix-test.zip" from the link below. You can extract it and replace the files in your POPM installed folder. All your user profile settings will not be affected.

https://github.com/hawkeye-stan/debug-and-support/releases/tag/POPM-Fenix-A320-Fix-Test

If the fix doesn't work, you can still roll back to previous v3.4.2 which was working for you. If this does work, please report back and I will create a hot fix to release to users who may have encountered this particular issue on their Fenix A320.

Thanks,
Stanley

from msfs-popout-panel-manager.

Delta-Charlie-DEV avatar Delta-Charlie-DEV commented on July 30, 2024

Hi Stanley, thanks for your replies. I downloaded the fix you mentionned, but with no effect on the problem.

I reverted to 3.4.2 and everything went fine again.

The problem doesn't seem to occur when the screen is popped out, but just after that, when the third screen is "separated" from the popped out window. In case that might help you, I recorded two videos : one with 3.4.2 and one with 3.4.3.

v3.4.2 (works fine) : https://youtu.be/Fx4naYv4fno

v3.4.3 (problem appears) : https://youtu.be/SnAwbmv3wV8

In case that might help, the panels locations and settings are:
image

And here is the .json config for this aircraft profile :

{"ProfileId":2,"ProfileName":"A320 FENIX","BindingAircrafts":["FNX320"],"PanelSourceCoordinates":[{"PanelIndex":1,"X":1812,"Y":1176},{"PanelIndex":2,"X":2359,"Y":1169},{"PanelIndex":3,"X":3296,"Y":1186},{"PanelIndex":4,"X":3283,"Y":1686}],"PanelConfigs":[{"PanelIndex":1,"PanelName":"Panel1","PanelType":2,"Top":2160,"Left":892,"Width":480,"Height":480,"AlwaysOnTop":true,"HideTitlebar":true,"FullScreen":false,"TouchEnabled":false,"DisableGameRefocus":false},{"PanelIndex":2,"PanelName":"Panel2","PanelType":2,"Top":2160,"Left":1371,"Width":480,"Height":480,"AlwaysOnTop":true,"HideTitlebar":true,"FullScreen":false,"TouchEnabled":false,"DisableGameRefocus":false},{"PanelIndex":3,"PanelName":"Panel3","PanelType":2,"Top":2160,"Left":1852,"Width":480,"Height":480,"AlwaysOnTop":true,"HideTitlebar":true,"FullScreen":false,"TouchEnabled":false,"DisableGameRefocus":false},{"PanelIndex":4,"PanelName":"Panel4","PanelType":2,"Top":2160,"Left":2333,"Width":480,"Height":480,"AlwaysOnTop":true,"HideTitlebar":true,"FullScreen":false,"TouchEnabled":false,"DisableGameRefocus":false}],"TouchPanelBindings":[],"BindingAircraftLiveries":[],"IsLocked":false,"PowerOnRequiredForColdStart":false,"IncludeInGamePanels":false,"MsfsGameWindowConfig":{"Top":0,"Left":0,"Width":0,"Height":0}}

from msfs-popout-panel-manager.

hawkeye-stan avatar hawkeye-stan commented on July 30, 2024

Hi Narvik-Ramius,

Thanks for the video. Looks like something is off with Windows OS display scale or coordinates after the first panel is popped out. In your video, the momentary display of number circles were elongated. I will look at the issue when I get home tonight and see what's going on. Hopefully, I can identify the cause and provide you a fix for your issue.

Stanley

from msfs-popout-panel-manager.

eyablonowitz avatar eyablonowitz commented on July 30, 2024

I am a new user of both the Fenix A320 and msfs-popout-panel-manager. I can report a similar issue. I say similar because it differs from the original report in two respects:

  1. I always get an error on panel 2 rather than 3. It doesn't matter what panel I select as panel 2 or the order.
  2. I can reproduce the issue with 3.4.2 as well as 3.4.3.

As with the original report, the issue seems to occur not at pop-out time but when the panel-manager attempts to separate the second panel from the first. Selecting a single panel also works fine which further adds to my confidence the issue is related to the separation not the initial pop-out.

from msfs-popout-panel-manager.

eyablonowitz avatar eyablonowitz commented on July 30, 2024

Got a screenshot of the separation. Looks like it may be clicking the wrong button?
image

from msfs-popout-panel-manager.

hawkeye-stan avatar hawkeye-stan commented on July 30, 2024

Hi eyablonowitz,

Thanks for the screenshot and it really helps me identify the problem. It looks like an issue with my app not getting the correct coordinates to click to separate the panel in rare configuration (such as in your Fenix A320). In the screenshot, when the "merged" left and right panel have very different scale (the right one is almost twice as wide than the left one), MSFS will scale them in a way that my app's calculated "estimate" coordinate about where to click is off. The higher resolution the monitor display, the less accurate it gets because the target header button area is so small.

I'll definitively look into this issue and implement more accurate way to find the header button to click and will release a fix ASAP.

As for a possible workaround in the meantime, if you make the panel on the left in your screenshot (the narrower one) as the last selection, it may be able to fix your issue?

Btw, would you be able to do me a favor and take a screen grab by using Windows 10/11 snipping tool of the merged "panel" window similar to the sample below? I just looked at my code and I had already built a workaround (just for Fenix A320) about an existing panel separate issue because I use color detection to identify the panel header bar to click. Fenix A320 panel header bar has different color gradient than all other aircrafts and it was not working correctly. It looks like this particular problem may have popped up again and I will need to find a better fix.

Screenshot 2022-08-20 215355

Thanks for your help,
Stanley

from msfs-popout-panel-manager.

hawkeye-stan avatar hawkeye-stan commented on July 30, 2024

Hi Narvik-Ramius, the issue that eyablonowitz is having maybe the same as yours. Hopefully, once I implement a fix, it will solve your issue also.

Stanley

from msfs-popout-panel-manager.

eyablonowitz avatar eyablonowitz commented on July 30, 2024

Thanks Stanley. Does this snip give you what you what you are looking for?
image

from msfs-popout-panel-manager.

hawkeye-stan avatar hawkeye-stan commented on July 30, 2024

This is perfect. I will try my best to figure out the issue and code a fix for you.

Stanley

from msfs-popout-panel-manager.

eyablonowitz avatar eyablonowitz commented on July 30, 2024

Actually realized the last capture was from a lower resolution that I tried as a failed attempt to workaround the issue. Not sure if it matters but here is an equiv at my normal 4K resolution.
image

from msfs-popout-panel-manager.

fabianovm avatar fabianovm commented on July 30, 2024

Hi Stanley, I did a first quick test - have to get kids from school now - and it WORKED OK, on first attempt on HJET. Just the FPS drop was massive, from 57fps to 30fps for 3 instruments poped out. If you know any trick to reduce this impact, let me know please! Will do more tests today, with time, and let you know in details, but yes, it seems you did the magic, thanks a lot!!!!!!!

from msfs-popout-panel-manager.

fabianovm avatar fabianovm commented on July 30, 2024

Glad the fix seems to be working!

As for pop out FPS drop, running the game with DX12 have no FPS penalty but if you're using Nvidia GPU, quite a few users have reported issue that the performance is not stable with current Nvidia driver in SU10. They're waiting for new GPU driver release in the next few days. As for AMD GPU which I have, DX12 runs almost as good as DX11 other than high VRAM usage in certain built-up area which could cause FPS drop. But when I need to fly VFR in the country or use pop out for an aircraft, I'll run the game in DX12.

-->Exactly what I was thinking , Iยดm on nvidia latest drivers dx11, think that the new driver and dx12 should help, because I know the FPS loss is on the msfs itself side, not on msfs popout manager side, it is beautiful now!! thanks a lot!!! will start the sim now, if I notice something else, let you know! have a nice weekend! Thanks a lot Stanley! Just curious, how many VRAM you have in your GPU?

from msfs-popout-panel-manager.

fabianovm avatar fabianovm commented on July 30, 2024

Good morning Stanley, just curious, how many VRAM you have in your GPU? Can you tell me the model just for comparision? thanks!

from msfs-popout-panel-manager.

fabianovm avatar fabianovm commented on July 30, 2024

Thanks for letting me know your VRAM, I have 10gb so it wold be ok with directx 12, like yours, thanks!

Bu the way, I used the msfs popout manager beta you sent me, for all day long yesterday and seems to work ok, did not see any problems on honda jet, thanks a lot!!!

from msfs-popout-panel-manager.

fabianovm avatar fabianovm commented on July 30, 2024

This fix will officially integrate into upcoming release 3.4.4

Thank you very much Stanley, I tried today with DX12 and latest drivers, no fps loss with popup, as you said, but sadly I have to tune the configs because my vram is on limit and the fps went below 30, 26, on landing, I will solve it soon!

best regards!

from msfs-popout-panel-manager.

hawkeye-stan avatar hawkeye-stan commented on July 30, 2024

Fix has been implemented in v3.4.4 release.

from msfs-popout-panel-manager.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.