I'm having trouble moving a simple message (my first step with this library). This

I can't repeat it in tests: <div class="highlight highlight-source-cs notranslate

I can't transmit a simple message [question] about h.pipes HOT 9 CLOSED

havendv commented on May 26, 2024 1

I can't transmit a simple message [question]

from h.pipes.

Comments (9)

atiris commented on May 26, 2024 1

Hm, this is possible bug with SystemTextJsonFormatter.
If I install H.Formatters.Newtonsoft.Json and change SystemTextJsonFormatter to NewtonsoftJsonFormatter, everything start working. Console log: Received: THIS IS TEST MESSAGE.
Well, I really lost a lot of time with this. 🙄

from h.pipes.

HavenDV commented on May 26, 2024 1

Thanks for the problem. I'll check. I want to note that be sure to call Dispose before closing the program / ending the use of PipeServer/PipeClient, otherwise you may have problems after restarting. Pipes are the resource of the entire system and must be properly cleaned after use.

from h.pipes.

atiris commented on May 26, 2024 1

I want to note that be sure to call Dispose before closing the program

Hi @HavenDV
thank you for this, I didn't really realize that. It would undoubtedly be a good idea to add this information to the readme.

from h.pipes.

HavenDV commented on May 26, 2024 1

It would undoubtedly be a good idea to add this information to the readme.

Updated README, added Notes block to Usage

from h.pipes.

atiris commented on May 26, 2024 1

I can't repeat it in tests

Thanks, I applied to the code everything I understood. This article https://devblogs.microsoft.com/dotnet/configureawait-faq/ requires a more advanced programmer than me 😄

Your test has probably been simplified to a level where serialization is not used as with a normal object.
Modified version of unit test:

namespace HPipesTests
{
    public class MyMessage
    {
        public string Text;
    }

    [TestClass]
    public class SystemTextJsonFm
    {
        [TestMethod]
        public async Task MessageString()
        {
            const string pipeName = "random_751902396";
            const string message = "THIS IS TEST MESSAGE";

            var receivedMessage = string.Empty;

            var server = new PipeServer<string>(pipeName, formatter: new SystemTextJsonFormatter());
            server.MessageReceived += (c, args) =>
            {
                Console.WriteLine($"Received: {args.Message}");

                receivedMessage = args.Message;
            };
            var startTask = server.StartAsync();

            var client = new PipeClient<string>(pipeName, formatter: new SystemTextJsonFormatter());
            client.Connected += async (o, args) =>
            {
                Console.WriteLine($"Sending: {message}");

                await client.WriteAsync(message);

                Console.WriteLine($"Sent: {message}");
            };
            await client.ConnectAsync();
            await startTask;

            await Task.Delay(TimeSpan.FromMilliseconds(100));

            Assert.AreEqual(message, receivedMessage);
        }

        [TestMethod]
        public async Task MessageClass()
        {
            const string pipeName = "random_54821002374";
            const string message = "THIS IS TEST MESSAGE";

            var receivedMessage = string.Empty;

            var server = new PipeServer<MyMessage>(pipeName, formatter: new SystemTextJsonFormatter());
            server.MessageReceived += (c, args) =>
            {
                Console.WriteLine($"Received: {args.Message.Text}");

                receivedMessage = args.Message.Text;
            };
            var startTask = server.StartAsync();

            var client = new PipeClient<MyMessage>(pipeName, formatter: new SystemTextJsonFormatter());
            client.Connected += async (o, args) =>
            {
                Console.WriteLine($"Sending: {message}");

                await client.WriteAsync(new MyMessage() { Text = message });

                Console.WriteLine($"Sent: {message}");
            };
            await client.ConnectAsync();
            await startTask;

            await Task.Delay(TimeSpan.FromMilliseconds(100));

            Assert.AreEqual(message, receivedMessage);
        }
    }
}

Result: 1 Passed / 1 Failed

from h.pipes.

HavenDV commented on May 26, 2024 1

Thanks, you're right, the problem started when I used your MyMessage class.

https://stackoverflow.com/questions/58139759/how-to-use-class-fields-with-system-text-json-jsonserializer
It is described in detail here. You just need to use the property.

public class MyMessage
{
    public string Text { get; set; }
}

There is also an option here to add JsonSerializerOptions { IncludeFields = true } to the SystemTextJsonFormatter. I need to understand what caused the refusal to serialize fields in the System.Text.Json library in order to make this decision.

from h.pipes.

HavenDV commented on May 26, 2024 1

For now, I've just added the ability to customize the SystemTextJsonFormatter via the Options property:

var server = new PipeServer<MyMessage>(pipeName, formatter: new SystemTextJsonFormatter { Options = { IncludeFields = true } });

from h.pipes.

HavenDV commented on May 26, 2024

I can't repeat it in tests:

[TestMethod]
public async Task ParallelTest()
{
    const string pipeName = "absolutely_random_name";
    const string message = "THIS IS TEST MESSAGE";

    var receivedMessage = string.Empty;

    var server = new PipeServer<string>(pipeName, formatter: new SystemTextJsonFormatter());
    server.MessageReceived += (c, args) =>
    {
        Console.WriteLine($"Received: {args.Message}");

        receivedMessage = args.Message;
    };
    var startTask = server.StartAsync();

    var client = new PipeClient<string>(pipeName, formatter: new SystemTextJsonFormatter());
    client.Connected += async (o, args) =>
    {
        Console.WriteLine($"Sending: {message}");

        await client.WriteAsync(message);

        Console.WriteLine($"Sent: {message}");
    };
    await client.ConnectAsync();
    await startTask;

    await Task.Delay(TimeSpan.FromMilliseconds(100));

    Assert.AreEqual(message, receivedMessage);
}

It works correctly.

I want to note that there are some peculiarities here when using asynchronous methods in Windows Forms. If you don't use ConfigureAwait(false), the default scheduler will be the UI scheduler. This can cause various problems with the initialization sequence.
Look towards using async void which contains try/catch inside. Also read this - https://devblogs.microsoft.com/dotnet/configureawait-faq/

from h.pipes.

HavenDV commented on May 26, 2024

Also try using Task.Run in general when creating the PipeServer, it might help.

from h.pipes.

I can't transmit a simple message [question] about h.pipes HOT 9 CLOSED

Comments (9)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent