Hoopl collection classes could use enummapset? about hoopl HOT 6 OPEN

On Sat, Oct 31, 2020 at 3:19 PM Håkan Thörngren ***@***.***> wrote: I have found myself using https://hackage.haskell.org/package/enummapset a lot in my code. It provides wrappers around IntSet/IntMap that uses Enum rather than Int, which allows for better type safety. Now I am doing more work with Hoopl in my project and it lacks certain useful functions from IntMap. I am looking at restrictKeys at the moment. I am trying to wrap my head around how to implement it, but I also realize that in some way this collection code in Hoopl is just the same thing as is also provided by enummapset. I was thinking that maybe it would better to migrate the code in Hoopl to make use of enummapset rather than rolling its own duplicate that tends to be out of date (I have added some missing functions before). I wonder what the maintainer and people using Hoopl think about this? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#53>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAYXSFNIZPJPFYHUI3ZDFCDSNSEO3ANCNFSM4TGEHZNQ> .

On Mon, Nov 2, 2020 at 12:59 AM simonpj ***@***.***> wrote: If it's just a question of boilerplate newtype wrappers, I'd be inclined to copy the necessary ones into hoopl, rather than take a dependency on another library. hoopl probably only uses half a dozen such functions. Let's see what the hoopl maintainers say. As to performance, I think that only newtype wrappers are involved, so perf impact should be zero. But worth checking anyway. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#53 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAYXSFJDCR7JMVMTTBLSV73SNZYHLANCNFSM4TGEHZNQ> .

On Mon, Nov 2, 2020 at 12:46 PM Håkan Thörngren ***@***.***> wrote: I support reimplementing the newtype wrappers in hoopl. So, how do you make it work? src/Compiler/Hoopl/Label.hs:106:27: error: • Couldn't match expected type ‘set’ with actual type ‘LabelSet’ ‘set’ is a rigid type variable bound by the type signature for: mapRestrictKeys :: forall set a. IsSet set => LabelMap a -> set -> LabelMap a at src/Compiler/Hoopl/Label.hs:106:3-17 • In the pattern: LS s In an equation for ‘mapRestrictKeys’: mapRestrictKeys (LM m) (LS s) = LM (restrictKeys m s) In the instance declaration for ‘IsMap LabelMap’ • Relevant bindings include mapRestrictKeys :: LabelMap a -> set -> LabelMap a (bound at src/Compiler/Hoopl/Label.hs:106:3) — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#53 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAYXSFK7L5JT3WGJUP7UPS3SN4LB7ANCNFSM4TGEHZNQ> .