Support for named routes in servant about servant-elm HOT 8 CLOSED

Looks like in the latest version of servant.foreign (0.16 as of writing) there is now support for this, though it still just uses the generated names (which tbh I'm fine with).

Version 0.16 isn't part of any stack lts yet though, so what I did was copy this into my code:

-- Taken from https://hackage.haskell.org/package/servant-foreign-0.16/docs/src/Servant.Foreign.Internal.html#line-518
-- But that is only available on servant-foreign 0.16, which is not in any stackage lts yet
instance HasForeign lang ftype (ToServantApi r) => HasForeign lang ftype (NamedRoutes r) where
  type Foreign ftype (NamedRoutes r) = Foreign ftype (ToServantApi r)

  foreignFor lang ftype Proxy req =
    foreignFor lang ftype (Proxy :: Proxy (ToServantApi r)) req

And then updated my generateElmModuleWith ... to:

  generateElmModuleWith
    ...
    (Proxy :: Proxy (ToServantApi Web.ApiRoutes))

(Added the ToServantApi there too essentially).

from servant-elm.

My guess is that you're missing the mode parameter on you API? My ApiRoutes looks like this:

data ApiRoutes mode = ApiRoutes
  { ping :: mode :- "ping" :> Get '[JSON] String,
    ...
  }
  deriving (Generic)

I also have type Api = NamedRoutes ApiRoutes but that's not the one I used ToServantApi on.

from servant-elm.

Sorry for that, thanks a lot!

from servant-elm.

An obvious issue is that records fields can have duplicate names accross different modules. This would mean that we would still need to speciy the path (possibly of other names) in the names of the generated functions.

from servant-elm.

This is also blocked by servant-foreign not supporting this, so you should probably create an issue there.

from servant-elm.

I see, thanks, I created an issue there: haskell-servant/servant#1673

from servant-elm.

I'm not sure I get it, I have this error:

    • Expected kind ‘Type -> Type’, but ‘API’ has kind ‘Type’
    • In the first argument of ‘ToServantApi’, namely ‘API’
      In the first argument of ‘Proxy’, namely ‘(ToServantApi API)’
      In an expression type signature: Proxy (ToServantApi API)
   |
42 |     (Proxy :: Proxy (ToServantApi API))
   |                                   ^^^

Any idea what's going on?

from servant-elm.