Code Monkey home page Code Monkey logo

Comments (4)

efeelaiho avatar efeelaiho commented on June 16, 2024

This is our documentation for custom domain: http://cloud/looker/docs/looker-core-custom-domain. It is expected behavior that the custom domain can only be added after instance creation. We do not plan to implement instance creation + custom domain as a single apply step.

So essentially we cannot expect this test to function in its current behavior. More than likely needs to be removed.

from terraform-provider-google.

nkhasuntsev avatar nkhasuntsev commented on June 16, 2024

Hi @efeelaiho ! Thanks for taking the time to have a look at this one. What's interesting is that the test worked fine when it was initially created in the og PR (GoogleCloudPlatform/magic-modules#9936), and the custom domain is supported by the Rest API (https://cloud.google.com/looker/docs/reference/rest/v1/projects.locations.instances#CustomDomain). We also already tested the custom_domain configuration in our Looker deployments and though we ran into a weird situation during domain verification (still investigating this one), the custom domain was created during instance creation.

from terraform-provider-google.

nkhasuntsev avatar nkhasuntsev commented on June 16, 2024

Also, it looks like more Looker tests are failing at the moment, so maybe it's a different cause?
#17394
#16715

from terraform-provider-google.

github-actions avatar github-actions commented on June 16, 2024

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

from terraform-provider-google.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.