Code Monkey home page Code Monkey logo

Comments (3)

lbajolet-hashicorp avatar lbajolet-hashicorp commented on July 26, 2024

Hi @saxonww,

That is a good idea indeed, and this should be reasonably easy to implement!
We probably won't do it too soon though since we're a bit busy with other things right now, but at first glance this should essentially be adding the Description to the CreateImageInput call for create ami, would you be available to open a PR for this? We'd be glad to help if that interests you, please let us know what you think!

from packer-plugin-amazon.

saxonww avatar saxonww commented on July 26, 2024

Hi @saxonww,

That is a good idea indeed, and this should be reasonably easy to implement! We probably won't do it too soon though since we're a bit busy with other things right now, but at first glance this should essentially be adding the Description to the CreateImageInput call for create ami, would you be available to open a PR for this? We'd be glad to help if that interests you, please let us know what you think!

Yeah I think so, I'm concerned about getting a good test written - I haven't looked at how to do that - but the rest of it seems easy.

from packer-plugin-amazon.

lbajolet-hashicorp avatar lbajolet-hashicorp commented on July 26, 2024

Yeah as far as testing goes this is likely a job for acceptance tests, I suggest you try the feature in your account, and we can write one after that, which we can then run in our account each week (there's a recurring job each Sunday for those).
I can assist when comes time to write the acceptance test, no worries about that!

from packer-plugin-amazon.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.