Hidden essid causes a crash in screen.py about wifibroot HOT 8 CLOSED

I've checked and this seems to be a bug within WiFiBroot when layers are dissected. Will fix it up and update

from wifibroot.

@wszacowny Can you make a pull request or show me the code you modified?

from wifibroot.

I assumed that ESSID lenght cannot exceed 32 characters, so I just added one line here :

for ap in self.__WiFiAP:
	ap['essid'] = ' ' if len(ap['essid']) > 32 else ap['essid']
	if self.verbose:
		tabulator__.append([ap['count'], ap['essid'], ap['pwr'], ap['auth'], ap['cipher'], \
				ap['psk'], ap['channel'], ap['bssid'].upper(), ap['vendor'], ap['clients']])
	else:
		tabulator__.append([ap['count'], ap['essid'], ap['pwr'], ap['auth'], ap['cipher'], \
				ap['psk'], ap['channel'], ap['bssid'].upper()])

Probably not perfect but it fixed my case.

from wifibroot.

I assumed that ESSID lenght cannot exceed 32 characters, so I just added one line here :

for ap in self.__WiFiAP:
	ap['essid'] = ' ' if len(ap['essid']) > 32 else ap['essid']
	if self.verbose:
		tabulator__.append([ap['count'], ap['essid'], ap['pwr'], ap['auth'], ap['cipher'], \
				ap['psk'], ap['channel'], ap['bssid'].upper(), ap['vendor'], ap['clients']])
	else:
		tabulator__.append([ap['count'], ap['essid'], ap['pwr'], ap['auth'], ap['cipher'], \
				ap['psk'], ap['channel'], ap['bssid'].upper()])

Probably not perfect but it fixed my case.

I can't use that, still an error.

But I have a workaround to fix that, we can strip value \x00 from ap['essid']

ap['essid'] = ap['essid'].rstrip('\x00')

And it's work for me as well. Tested on Backbox Linux (Ubuntu 18)

for ap in self.__WiFiAP:
				ap['essid'] = ap['essid'].rstrip('\x00')
				if self.verbose:
			 		tabulator__.append([ap['count'], ap['essid'], ap['pwr'], ap['auth'], ap['cipher'], \
			 				ap['psk'], ap['channel'], ap['bssid'].upper(), ap['vendor'], ap['clients']])
			 	else:
			 		tabulator__.append([ap['count'], ap['essid'], ap['pwr'], ap['auth'], ap['cipher'], \
			 				ap['psk'], ap['channel'], ap['bssid'].upper()])

That ESSID has indicated as Hidden ESSID.

from wifibroot.

Hi, thanks for the workaround. Can you open pull request for this? I would not be able to look at this for atleast a month.

from wifibroot.

@mirfansulaiman

from wifibroot.

Hi, thanks for the workaround. Can you open pull request for this? I would not be able to look at this for atleast a month.

Sure :)

from wifibroot.

@mirfansulaiman Thanks. Closing it now and putting it in solved.

from wifibroot.