Context Manager / set_event_loop & event loop policies about quamash HOT 3 CLOSED

@aknuds1 said:

It's better to stick with the standard, so I agree, get rid of the context manager installation side effect (providing that this is non-standard behaviour, I haven't double checked).

However, isn't it still a good idea to use the context manager to close the loop after it's done with?

Well, having the context manager and close the loop without setting it seems weird. I was gonna say that it violates the with-statement PEP, but it obviously doesn't since that's exactly how open() and contextlib.closing work. (w/o a builtin context manager, it would still work with contextlib.closing)

I'm not sure that shutting down the event loop is even necessary, unless you're going to start a new one. (which is weird). It will automatically get shut down when the process exits which is fine.

from quamash.

Yeah, I don't understand how having the context manager only close the loop would be weird, since that's typical behaviour. So there are two aspects here I think:

1. Please keep the context manager, for closing the loop. One can otherwise use contextlib.closing, but it's smoother not having to reach for this.
2. While it's not necessary to close the loop in the example, I think it's good to promote the pattern of freeing your resources. Sometimes you might open a loop that's going to be disposed before the program ends.

from quamash.

I don’t think that having a QEventLoopPolicy is required. However, it is a nice-to-have and the possible features this would allow definitely sound neat to me. I think a step-by-step approach is appropriate here.

I have no strong opinion on the contextmanager, I don’t use it myself.

my two cents

from quamash.