Use the requests library for all the requests. about cli-github HOT 8 CLOSED

@SanketDG isn't future added here for py2/3 compatibility? Also, adding requests seems like a good idea, but IMO I don't think it's worth adding a dependency; as in this case, performance gains are not much.

from cli-github.

@sananth12
I meant that urllib's api is different for Python2 and Python3.
Requests has got a much cleaner api and is used extensively, also a cleaner syntax. When this library goes into authentication and stuff, then requests is really going to come in handy. But that's okay if it's way too trivial.

from cli-github.

@sananth12 @harshasrinivas Any interest on moving this forward?

from cli-github.

I agree with @sananth12.
And by the way @SanketDG , future is added here for Python 2-3 compatibility, not only for urllib.

from cli-github.

@harshasrinivas
Sorry for my bad choice of words, but I didn't mean anything about future at all, what I meant was the differences in urllib's api for py2 and py3 and using requests really has a lot of advantages. I don't know why adding a dependency could be a big deal, plus urllib is pretty limited.

from cli-github.

Alright @SanketDG, lets go with requests. You can send me a pull.

from cli-github.

👍 Seems good to me.

from cli-github.

@harshasrinivas @sananth12 Really sorry for all of this confusion, but upon further inspection of the code, I have finally realized its way too trivial, given the current size of the codebase. urllib is more suited as of now.
Once again, sorry. Closing this.

from cli-github.