Comments (8)
@SanketDG isn't future added here for py2/3 compatibility? Also, adding requests seems like a good idea, but IMO I don't think it's worth adding a dependency; as in this case, performance gains are not much.
from cli-github.
@sananth12
I meant that urllib's api is different for Python2 and Python3.
Requests has got a much cleaner api and is used extensively, also a cleaner syntax. When this library goes into authentication and stuff, then requests is really going to come in handy. But that's okay if it's way too trivial.
from cli-github.
@sananth12 @harshasrinivas Any interest on moving this forward?
from cli-github.
I agree with @sananth12.
And by the way @SanketDG , future is added here for Python 2-3 compatibility, not only for urllib
.
from cli-github.
@harshasrinivas
Sorry for my bad choice of words, but I didn't mean anything about future at all, what I meant was the differences in urllib
's api for py2 and py3 and using requests
really has a lot of advantages. I don't know why adding a dependency could be a big deal, plus urllib
is pretty limited.
from cli-github.
Alright @SanketDG, lets go with requests
. You can send me a pull.
from cli-github.
👍 Seems good to me.
from cli-github.
@harshasrinivas @sananth12 Really sorry for all of this confusion, but upon further inspection of the code, I have finally realized its way too trivial, given the current size of the codebase. urllib
is more suited as of now.
Once again, sorry. Closing this.
from cli-github.
Related Issues (14)
- Argparse in setup HOT 1
- Add LICENSE HOT 1
- Option to not use os environment token. HOT 1
- No tests HOT 1
- Multiple commits
- not able to auth HOT 4
- Invalid Credentials HOT 5
- Content of any file HOT 2
- [Suggestion] Why have two different options for the same feature? (-n and -u) HOT 1
- Feature Request: More information about the user. HOT 1
- cli-github -n does not work HOT 1
- Don't need metadata for rst files HOT 3
- Use pypandoc to eliminate need of README.rst HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cli-github.