Enable ListenAndServeTLS for https support about gitness HOT 9 CLOSED

at the moment it needs to be enabled behind a reverse proxy (like nginx). the only caveat is that you also need to enable websockets, which looks something like this:

    # Proxy for websockets
    location = /feed {
        proxy_set_header X-Real-IP $remote_addr;
        proxy_set_header X-Forwarded-For $remote_addr;
        proxy_set_header Host $http_host;

        proxy_pass http://127.0.0.1:8898;
        proxy_redirect off;

        proxy_http_version 1.1;
        proxy_set_header Upgrade $http_upgrade;
        proxy_set_header Connection "upgrade";
    }

from gitness.

Thank you for the answer! I think it would be nice to add it to the README.md in case others want to enable HTTPS too.

from gitness.

will do!

also, the code change for adding SSL support to Drone is fairly simple. We can accept the key pair as command line args. If the args exists, we can start the server like this:

http.ListenAndServeTLS(addr,  "cert.pem", "key.pem", nil)

from gitness.

It would be awesome! Should I add PR or you’ll do it?

On Feb 25, 2014, at 9:21 AM, Brad Rydzewski [email protected] wrote:

will do!

also, the code change for adding SSL support to Drone is fairly simple. We can accept the key pair as command line args. If the args exists, we can start the server like this:

http.ListenAndServeTLS(addr, "cert.pem", "key.pem", nil)
—
Reply to this email directly or view it on GitHub.

from gitness.

PRs are always welcome :) but I'm happy to add the feature if you don't get around to it

from gitness.

Thank you! Sure, will be waiting for that feature :-)

On Feb 25, 2014, at 9:33 AM, Brad Rydzewski [email protected] wrote:

PRs are always welcome :) but I'm happy to add the feature if you don't get around to it

—
Reply to this email directly or view it on GitHub.

from gitness.

Was about to write a ticket for this.

Just spinning up drone at the moment to play around with, looks awesome but would love the option of HTTPS.

Will add some flags and listener code.

from gitness.

just merged

@OShalakhin you can use the --sslcert and --sslkey command line arguments to start drone with https support. It would look something like this:

droned --sslcert="path/to/cert.pem" --sslkey="/path/to/key.pem"

from gitness.

Thank you! Awesome! :)

from gitness.