GitHub Enterprise & http:// about gitness HOT 4 CLOSED

Well, storing github_url will not work with this code. I'm starting to think, that sources of code should be abstracted. I read discussion about it in issue about self-hosted git.

from gitness.

I can think of a couple of options for this code

option 1
We could execute url.Parse() to extract the Host from the url

option 2
We could pass enterprise.github.com as the host value for github enterprise. Depending on how we abstract the code, we may end up needing the host value to be fixed, as opposed to a variable domain name. TBD

other options?

from gitness.

We could add github_url_scheme that can be http or https

from gitness.

I like url.Parse() more than another option in settings.

from gitness.