GitHub caching badge, causing problems about gitness HOT 3 CLOSED

As a workaround, for anyone using drone via reverse proxy like nginx.
You can always tell nginx to add Cache-Control no-cache header,
I use something like this on my instance:

    location ~ ^/img/build_.+\.png$ {
        proxy_pass http://drone;
        proxy_set_header  X-Real-IP  $remote_addr;
        proxy_set_header  X-Forwarded-For  $remote_addr;
        proxy_set_header Host $host;
        add_header Cache-Control no-cache;
    }

As for drone itself, it looks like we should use custom handler and use
http.ServeFile instead, then we can check r.URL.Path and set Cache-Control header
if it requests for /img/build_*.png. @bradrydzewski what do you think?

from gitness.

ahh, I might know the issue

We are setting cache-control headers for all requests:
https://github.com/drone/drone/blob/master/cmd/droned/drone.go#L178

However, this doesn't include our static assets:
https://github.com/drone/drone/blob/master/cmd/droned/drone.go#L73

We are serving the images using http.ServeFile:

http.Handle("/img/", http.FileServer(box.HTTPBox()))

We can probably wrap the FileServer in a function that, as you suggested, inspects the URL path and applies the cache-control header if /img/build_*.png

from gitness.

ok, added a fix here
https://github.com/drone/drone/blob/master/cmd/droned/drone.go#L80

from gitness.