Branch names with slashes are not properly handled about gitness HOT 9 CLOSED

ahh, ok, looks like we should add a field called "branch_slug" that removes any characters that aren't URL friendly. We already have a helper function for this:
https://github.com/drone/drone/blob/master/pkg/model/util.go#L34

Off the top of my head, we'll need to:

1. add BranchSlug to the Commit struct
2. add the database column and index it
3. alter any sql queries that use branch to use branch_slug
4. alter any templates that use branch when constructing the URL and switch to branch_slug
5. alter the badge template and badge code to use branch_slug

from gitness.

ahh, ok, looks like we should add a field called "branch_slug" that removes any characters that aren't URL friendly.

I would use the branch HEAD SHA1 rather than generate a "not-so friendly" slug

from gitness.

We let you filter your build history in the UI based on branch. The URL pattern follows a similar convention to GitHub: /github.com/:owner/:name/tree/:branch

Drone: https://localhost:8080/github.com/drone/drone/tree/master
GitHub: https://github.com/drone/drone/tree/master

I haven't looked, but I'm guessing GitHub strips non-friendly URL characters out of its branches as well?

from gitness.

I haven't looked, but I'm guessing GitHub strips non-friendly URL characters out of its branches as well?

• slash chars are not stripped at least: https://github.com/nvie/gitflow/tree/feature/implement-hooks
• branch sha1 is also valid on GH: https://github.com/drone/drone/tree/088c45941cc3105ef0f400c4455dd816525b2a81

from gitness.

ok, thanks for that info!

for now, we can just escape the branch value in our template:

{{ .Branch | html }}

this should get things working without having to commit to a specific approach just yet. I'm working on a patch now.

from gitness.

Great! also according to pat documentation:

replacing:

    m.Get("/:host/:owner/:name/tree/:branch", handler.RepoHandler(handler.RepoDashboard))

with:

    m.Get("/:host/:owner/:name/tree/:branch/", handler.RepoHandler(handler.RepoDashboard))

should make it work too

from gitness.

I wasn't able to get the pat route to work with the trailing slash :(

So for now we're using url query parameters. I'm not in the love with the approach, but at least it makes the system usable. feel free to pull the latest .deb to upgrade

from gitness.

Hey @bradrydzewski I think this is an issue in the 0.3 branch. If we uses /'s the UI doesn't work properly but if we use _ instead it appears.

from gitness.

Yes, I changed how we handle branches from 0.2 to 0.3 we'll need to update our server-side routes to use regular expressions to accomodate slashes /v1/api/repos/{host}/{owner}/{name}/branches/{branch:(.+)}

from gitness.