Code Monkey home page Code Monkey logo

Comments (21)

bradrydzewski avatar bradrydzewski commented on August 19, 2024

I need to copy / paste code from our cloud edition (at drone.io) into the open source edition. It is probably a 2 hour exercise. Should be available some time next week. I'll keep you updated

from gitness.

estsauver avatar estsauver commented on August 19, 2024

Hey Brad, that's super exciting. Thanks for adding bit bucket.

from gitness.

f3rno avatar f3rno commented on August 19, 2024

Any ETA on this? :) It'd be great to have.

from gitness.

kennethkalmer avatar kennethkalmer commented on August 19, 2024

Must say I'm desperate for this integration too.

from gitness.

lensvol avatar lensvol commented on August 19, 2024

Is it gonna be just for Git repositories from Bitbucket? I'm planning to work on integrating Drone with Mercurial and don't want to step on anyone's toes.

from gitness.

benallard avatar benallard commented on August 19, 2024

You should watch out as the cloud based product already has mercurial
support, so there already is code to support that. The question is if the
license allow them to publish it or not ... If not, it would have to be
re-written anyway, if yes, that would be pretty bad to duplicate the effort
...

On Thu, Feb 27, 2014 at 10:00 PM, Kir [email protected] wrote:

Is it gonna be just for Git repositories from Bitbucket? I'm planning to
work on integrating Drone with Mercurial and don't want to step on anyone's
toes.

Reply to this email directly or view it on GitHubhttps://github.com//issues/2#issuecomment-36290805
.

from gitness.

lensvol avatar lensvol commented on August 19, 2024

That's what I am trying to learn. We are medium-sized (150+ developers) Mercurial-based company and have about 30 private repos, so in-house installation of Drone makes a lot of sense. But Mercurial support is a dealbreaker, so is there any roadmap on inclusion of features from cloud based product? If there is no plans to do it, I would like to start working on it in spare tme.

from gitness.

bradrydzewski avatar bradrydzewski commented on August 19, 2024

I have most of the code written already in a local branch. It was copied and pasted from our cloud version (at drone.io). I will publish as soon as it is ready.

I really appreciate the offer to help. I'll definitely need help testing once I publish the changes.

from gitness.

kennethkalmer avatar kennethkalmer commented on August 19, 2024

I'm on the opposite boat, an army-of-one that is desperately trying to use bitbucket+git and avoid having to install another Jenkins instance. I'll cover that part of the testing, as long as the code gets up.

Thanks guys for this promising project

from gitness.

lensvol avatar lensvol commented on August 19, 2024

Thanks! We'd appreciate any help getting away from tyranny of Jenkins. :)

Btw, would it be acceptable to work on supporting in-house Mercurial repositories, like RhodeCode and such?

from gitness.

pigmej avatar pigmej commented on August 19, 2024

Count me in + my company for testing too.

Looking forward to drop jenkins :)
-----Original Message-----
From: Kir [email protected]
Date: Fri, 28 Feb 2014 01:22:51
To: drone/[email protected]
Reply-To: drone/drone [email protected]
Subject: Re: [drone] Bitbucket support (#2)

Thanks! We'd appreciate any help getting away from tyranny of Jenkins. :)


Reply to this email directly or view it on GitHub:
#2 (comment)

from gitness.

benallard avatar benallard commented on August 19, 2024

@lensvol, the trouble with bare repository (out of github or bitbucket) is to get notifications from them (including meta information like author, files, revision, branch, ...), or extract information (think about the .drone.yaml) without having to clone the repository first : you actually want to boot docker first ... While I believe that there definitively is interest for such a feature, it might be a long road ...

from gitness.

lensvol avatar lensvol commented on August 19, 2024

@benallard I wasn't bare repository as such (e.g. hgweb), but full-blown wrappers like RhodeCode. More often then not they support post-commit hooks and API calls, so it may be possible to conveniently instruct information you mentioned.

from gitness.

f3rno avatar f3rno commented on August 19, 2024

@bradrydzewski Any ETA? Bitbucket support seems like a pretty huge thing to have, since many people use bitbucket for private repos (as opposed to Github, where you can use Travis CI).

from gitness.

bradrydzewski avatar bradrydzewski commented on August 19, 2024

I copied and pasted from the drone.io website into a branch:
https://github.com/drone/drone/blob/bitbucket/pkg/handler/bitbucket.go

It compiles. That is about as far as I got. Things that still need to be done:

  • hook up the handlers to the router
  • add form fields for saving the bitbucket key / secret on the admin page
  • add templates for bitbucket (pretty much same as github templates)

And of course actual testing. Since there is a lot of interest I figured I'd push the branch and give people the opportunity to chip in and accelerate this feature.

from gitness.

bradrydzewski avatar bradrydzewski commented on August 19, 2024

Initial Bitbucket Git support was merged in #232. Thanks @asabil for the effort! Everyone should feel free to start testing.

The code still needs some refactoring and test coverage. I'm documenting my notes here, since I accidentally closed the PR.

  1. the bitbucket handlers should all be in a struct called BitbucketHandler. See https://github.com/bradrydzewski/drone/blob/bitbucket/pkg/handler/bitbucket.go
  2. the BitbucketHandler struct should be in a bitbucket.go file.
  3. we need test coverage, similar to GitHub. See https://github.com/drone/drone/blob/master/pkg/handler/testing/github_test.go

from gitness.

1371760 avatar 1371760 commented on August 19, 2024

Just started testing bitbucket support. Works great, but only for master branch. Is there any way to specify another branch?

from gitness.

bradrydzewski avatar bradrydzewski commented on August 19, 2024

@1371760 I haven't tested this myself, but looking over the code this is how I would expect it to work:

  1. setup your Bitbucket project in Drone and include a .drone.yml
  2. git push your code to a non-master branch
  3. post-commit hook is sent to Drone with branch and commit number in payload
  4. build is triggered for that branch and commit number

You can see here where the branch and commit data are extracted:
https://github.com/soundrop/drone/blob/8f4f747c864f7bfd4b11653127f2a7c2ac911cfa/pkg/handler/hooks.go#L331

Note that Drone will not build the same commit twice. So if you are pushing a commit to a branch that was already built, it will be ignored. You can see that logic here:
https://github.com/soundrop/drone/blob/8f4f747c864f7bfd4b11653127f2a7c2ac911cfa/pkg/handler/hooks.go#L324

If this is not bahaving as described above please provide more detail so that @asabil can troubleshoot. thanks!

from gitness.

1371760 avatar 1371760 commented on August 19, 2024

Thanks @bradrydzewski ! All work as described! There was a problem because drone does not build the same commit twice. In my case I have production and test environments and master and test branches, with different .drone.yml stored in test and master branches and added to .gitignore. When I want to test extra feature I just push to test branch with test .drone.yml configuration and when I want to deploy to production I just merge with test branch and push it. There was no effects, because drone does not build the same commit twice. In this case I have to add "blank" commit to master branch to get build action. But still, great job!

P.S. Is there any way to browse "workspace" (jenkins term)? My build generate test result in html. I would like to add link to badge and get test result right from email letter.

from gitness.

bradrydzewski avatar bradrydzewski commented on August 19, 2024

Great, glad it is working! There is an open issue somewhere for using branch+commit as the unique combination instead of just commit to support the exact use case you described.

Is there any way to browse "workspace" (jenkins term)? My build generate test result in html.

There is no support for workspaces since a new virtual machine is created and destroyed for each build. There is support for publishing artifacts to S3 and Rackspace cloud files. We also plan to add reporting plugins at some point

I would like to add link to badge

Badges are supported. You can get the badge link by going to your repository settings > badges

and get test result right from email letter.

You can get pass / failure emails by configuring email notifications in your .drone.yml. This email will include the overall pass / fail status of your build and a link to the results, however, will not include the detailed results directly in the email

from gitness.

1371760 avatar 1371760 commented on August 19, 2024

Thanks @bradrydzewski !

from gitness.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.