Code Monkey home page Code Monkey logo

Comments (7)

harjot-oberai avatar harjot-oberai commented on August 10, 2024 1

@IzzySoft : Thank you very much.
I added the release apk today here on github after reading @Poussinou comment. Then I remembered that you had offered to upload the apk on your F-Droid repo. Sorry for keeping you waiting for so long.

Also the READ_PHONE_STATE permission; I have received at least 10 bad reviews just for that. Thanks for suggesting the workaround, I'll surely implement it as soon as possible.

I will add the F-Droid banner as well and link your repo to it 👍

from musicdna.

IzzySoft avatar IzzySoft commented on August 10, 2024 1

@harjot-oberai if you've implemented the alternative approach to "phone state", please let me know (including how difficult it was, and maybe hints you would give to other developers to save them some headaches). Might convince some of them, and make several apps "look cleaner" 😉

PS: I just learned about the effect an F-Droid icon with a download link behind it can have. 284 downloads of the .apk already on my end – which makes 15+ downloads a day on average 🙀😜 As only 77 "referrers" account for your GH repo, it seems it's picked up directly via the F-Droid client pretty well, too 😇

from musicdna.

IzzySoft avatar IzzySoft commented on August 10, 2024

And if you find that too troublesome: maybe you at least consider adding the .apk here at Github (best in releases/, see Creating Releases)? I could then pick it up and add it to my F-Droid compatible repo, keeping your signature. Updates would then be available within 24h of your adding them here :)

from musicdna.

Poussinou avatar Poussinou commented on August 10, 2024

This app on F-Droid will be amazing !

from musicdna.

IzzySoft avatar IzzySoft commented on August 10, 2024

@Poussinou It is, in a way now. You'd just need to add my repo to your F-Droid client 😺

The "official repo" might choke on e.g. Crashlytics, which is integrated with the player, and thus not accept it.

@harjot-oberai For an alternative to require the READ_PHONE_STATE (which in connection with INTERNET always looks suspicious, as thanks to some ad networks the first thought is you might wish to transmit device IDs), take a look at my post here. There are ways to detect an incoming call by other means that via that permission. In short, as an incoming call "rings the bell", just register for the onAudioFocusChange(); then check whether it was triggered by a call (checking current CallState does not require any permission). Just as a hint 😜

from musicdna.

IzzySoft avatar IzzySoft commented on August 10, 2024

@harjot-oberai Yeah, that's what I meant by "looking suspicious". Some US president once said, "90% of our politicians make the remaining 10% look bad", same here: There've been too many abuses in the past, and permissions are very far from being fine-grained. Unfortunately, the way via READ_PHONE_STATE is the one recommended via the developer docs, and at that the only one mentioned (and really easy to implement, as far as I've heard – I'm not an Android dev myself, just an "Android Enthusiast" trying to make the world a better place 😸 ). The work-around I recommended is a bit harder, keeping my fingers crossed for an easy go! Maybe one day someone makes that a little module others can simply add to their apps (wink, wink ;)

I added the release apk today here on github

Thanks a lot, in the name of all your users who wanted that – present and future :)

I will add the F-Droid banner as well and link your repo to it 👍

Very much appreciated, thanks! Makes it easier for interested users to find it!

from musicdna.

Poussinou avatar Poussinou commented on August 10, 2024

Thanks a lot guys, you're amazing :) this app is beautiful

from musicdna.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.