Breaking change about nestjs-dynamoose HOT 10 CLOSED

dude, you really need to do the semantic versioning and change the major version when involves breaking changes.

from nestjs-dynamoose.

@ianzone I will try my best to keep semantic versioning...

from nestjs-dynamoose.

After further investigation, even after upgrading the config to the new version, table name settings were not able to read from config service:

import { DynamooseModule } from 'nestjs-dynamoose';
import { UserSchema } from './user.schema';
import { UserService } from './user.service';

@Module({
  imports: [
    ConfigModule.forRoot({ isGlobal: true }),
    DynamooseModule.forFeatureAsync([
      {
        name: 'User',
        useFactory: (_, configService: ConfigService) => {
          return {
            schema: UserSchema,
            options: {
              tableName: configService.get<string>('USER_TABLE_NAME'),  <-- This won't work anymore, table name defaults to User automatically.
            },
          };
        },
        inject: [ConfigService],
      },
    ]),
  ],
  providers: [
    UserService,
    ...
  ],
})
export class UserModule {}

from nestjs-dynamoose.

@onurkose i just tested without any problem, are u using dynamoose version 3.2.0?

from nestjs-dynamoose.

yes, it's dynamoose 3.2.0
I just downgraded nestjs-dynamoose to 0.5.3 and it works just fine.

from nestjs-dynamoose.

@onurkose I tested using aws-nestjs-starter without any problem, since it won't use the dynamoose auto table create feature, if you are using dynamoose auto table create feature, please report to dynamoose about this bug.

from nestjs-dynamoose.

15a06f2 should only affect a model name, and not a table name.

It would be great if you fork aws-nestjs-starter and reproduce your problem so that i can debug it and contribute a hot fix

from nestjs-dynamoose.

@onurkose I also tested the dynamoose auto create table feature using options.tableName, it also works correctly.

from nestjs-dynamoose.

I confirm this issue. The "tableName" doesn't work anymore. It created a "tenants" table based on the "name".

from nestjs-dynamoose.

and this works.

from nestjs-dynamoose.