Revamp comment.sh shell script about leetcode HOT 8 CLOSED

They use the GraphQL API, I will update my script soon.

very soon......

from leetcode.

@shwsun please test the new scripts

from leetcode.

Hi, I think there are only two slight problems:

1. in the query_problem.sh we should use -s instead of -q since that is already deprecated.
2. the question description is not really inserted into the source_file, I think the ${TMP_FILE} should be ${source_file}.

from leetcode.

for 1), you mean the option for xidel command should use -s rather than -q ? (the xidel acutally hasn't -s option)

for 2), the ${TMP_FILE} is a temporary file which will be insert into $source_file late.

#insert the problem description into the source file, and remove it
sed -i.bak '4 r '${TMP_FILE}'' ${source_file}

may I know more details?

from leetcode.

@shwsun any feedback?

from leetcode.

@haoel I am pretty sure about the param problem. Is it because of the newer version of xidel?

[~/repos/leetcode/scripts]-[master↓]── - xidel -q
-quiet,-q is outdated. Use --silent,-s

Re the other issue, the comment.sh still can't get the problem description into the file from my side.

[~/repos/leetcode/scripts]-[master↓]── - ./comments.sh https://leetcode.com/problems/largest-number/

-quiet,-q is outdated. Use --silent,-s
-quiet,-q is outdated. Use --silent,-s
-quiet,-q is outdated. Use --silent,-s
-quiet,-q is outdated. Use --silent,-s
-quiet,-q is outdated. Use --silent,-s
./comments.sh: line 85: [: ==: unary operator expected
Create a new file - LargestNumber.cpp.
LargestNumber.cpp updated !
[~/repos/leetcode/scripts]-[master↓]── - cat LargestNumber.cpp 
// Source : https://leetcode.com/problems/largest-number/
// Author : shwsun
// Date   : 2018-02-05

/*************************************************************************************** 
 *
 * 
 ***************************************************************************************/

I am running Ubuntu, could you get a Linux and test it a bit?

from leetcode.

Thanks for more information.

Yes, the script I only tested on MacOS. And on linux platform, xidel rename the -q option to -s after version 0.9.4, so I need to check the options.

Now, I fix it in commit 0fdf100

from leetcode.

I am going to close this issue, @shwsun you can reopen it if anything's still problem

from leetcode.